From: Christoph Hellwig <hch@infradead.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-fsdevel@vger.kernel.org, hch@infradead.org,
viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org,
"J. Bruce Fields" <bfields@citi.umich.edu>,
NeilBrown <neilb@suse.de>
Subject: Re: [patch 4/8] nfsd: rename MAY_ flags
Date: Thu, 29 May 2008 08:47:01 -0400 [thread overview]
Message-ID: <20080529124701.GA13147@infradead.org> (raw)
In-Reply-To: <20080529113312.288347247@szeredi.hu>
On Thu, May 29, 2008 at 01:32:49PM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@suse.cz>
>
> Rename nfsd specific MAY_* flags to NFSD_MAY_* to make it clear, that
> these are not used outside nfsd, and to avoid namespace conflicts with
> the VFS.
But they _are_ in the same namespace as the VFS ones. This needs to be
sorted out by real by understanding what's going on here and either
separating this flags out and passing them in a separate argument, or
moving them to include/linux/fs.h so it's obvious for anyone adding new
flags that they must not collide. In that later case it might make
sense to add add a NFSD in the name, although MAY_NFSD_* makes more
sense to keep a unique prefix.
next prev parent reply other threads:[~2008-05-29 12:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 11:32 [patch 0/8] vfs: more cleanups and fixes Miklos Szeredi
2008-05-29 11:32 ` [patch 1/8] vfs: dcache cleanups Miklos Szeredi
2008-05-29 12:23 ` Matthew Wilcox
2008-05-31 8:18 ` Christoph Hellwig
2008-05-29 11:32 ` [patch 2/8] vfs: fix sys_getcwd for detached mounts Miklos Szeredi
2008-05-31 8:20 ` Christoph Hellwig
2008-05-29 11:32 ` [patch 3/8] Make d_path() consistent across mount operations Miklos Szeredi
2008-05-31 8:22 ` Christoph Hellwig
2008-06-01 20:38 ` Miklos Szeredi
2008-06-02 5:55 ` Christoph Hellwig
2008-05-29 11:32 ` [patch 4/8] nfsd: rename MAY_ flags Miklos Szeredi
2008-05-29 12:47 ` Christoph Hellwig [this message]
2008-05-29 14:02 ` Miklos Szeredi
2008-05-29 20:40 ` J. Bruce Fields
2008-05-30 7:36 ` Christoph Hellwig
2008-05-30 9:07 ` Miklos Szeredi
2008-05-30 9:53 ` Miklos Szeredi
2008-05-30 20:12 ` J. Bruce Fields
2008-05-29 11:32 ` [patch 5/8] vfs: annotate permission operations Miklos Szeredi
2008-05-31 8:23 ` Christoph Hellwig
2008-05-29 11:32 ` [patch 6/8] Factor out sysctl pathname code Miklos Szeredi
2008-05-31 8:27 ` Christoph Hellwig
2008-06-03 13:34 ` Stephen Smalley
2008-05-29 11:32 ` [patch 7/8] vfs: clean up getattr API Miklos Szeredi
2008-05-29 11:32 ` [patch 8/8] vfs: create file_remove_suid() helper Miklos Szeredi
2008-05-31 8:29 ` Christoph Hellwig
2008-06-01 20:45 ` Miklos Szeredi
2008-06-02 6:05 ` Christoph Hellwig
2008-06-02 7:06 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080529124701.GA13147@infradead.org \
--to=hch@infradead.org \
--cc=bfields@citi.umich.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=neilb@suse.de \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox