Re: [patch 01/15] security: pass path to inode_create

Miklos Szeredi
2008-06-02T09:53:30Z

> > You act like a happy prince of VFS, but let me tell you one thing,
> > there's only one king in this kingdom of Linux, and that's Linus
> > Torvalds I. And our wise king already said that apparmor can come, so
> > the question is not "if" but "how".
> >
> > If you don't want to help, that's a pity, but of course I don't want
> > to (and can't) force you. I can understand if personally you don't
> > think this is a good idea, and don't want to have anything to do with
> > it. In that case I can leave you off the CC's for the parts which are
> > not just generic VFS cleanups but explicitly towards apparmor
> > integration. Would that suit you?
>
> No,

So shall I leave you _on_ the CC's then?

> and Agenda doesn't make these patches any better.

Umm, what's wrong with the patches then? What exactly do they break?
How do they make the kernel bigger and slower? How do they make the
code less readable?

These patches fix several issues raised at previous submissions:

- passing NULL vfsmounts
- using nameidata
- using extra stack for vfsmount argument

So, it seems to me that there's in fact no issues remaining and the
best excuse you can come up with is that it's a dumb idea. Well,
that's not a very imressive technical argument IMNSHO.

Miklos