From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@osdl.org, akpm@linux-foundation.org,
dhowells@redhat.com, bunk@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] Werror: Hide epca_setup() as it's unused
Date: Thu, 29 May 2008 19:35:13 +0100 [thread overview]
Message-ID: <20080529193513.0b6811b9@core> (raw)
In-Reply-To: <20080529181731.5396.42286.stgit@warthog.procyon.org.uk>
On Thu, 29 May 2008 19:17:31 +0100
David Howells <dhowells@redhat.com> wrote:
> Hide epca_setup() by encasing it in #if 0 as it's unused.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
NAK - we don't hide bugs, we fix em.
EPCA setup either needs calling, or as I suspect is the case epca needs
deleting. Hiding the warning isn't useful
next prev parent reply other threads:[~2008-05-29 18:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 18:17 [PATCH 1/6] Werror: Fix casting wrong size integer to pointer David Howells
2008-05-29 18:17 ` [PATCH 2/6] Werror: Hide epca_setup() as it's unused David Howells
2008-05-29 18:35 ` Alan Cox [this message]
2008-05-29 18:17 ` [PATCH 3/6] Werror: Remove iiEllisCleanup() " David Howells
2008-05-29 18:28 ` Adrian Bunk
2008-05-29 19:07 ` David Howells
2008-05-29 18:35 ` Alan Cox
2008-05-29 18:17 ` [PATCH 4/6] Werror: Hide warnings on static module device tables David Howells
2008-05-29 19:24 ` Adrian Bunk
2008-05-29 19:41 ` David Howells
2008-05-29 19:50 ` Adrian Bunk
2008-05-29 18:17 ` [PATCH 5/6] Werror: Remove the packed attribute from PofTimStamp_tag in the hysdn driver David Howells
2008-05-29 19:24 ` Andrew Morton
2008-05-29 18:17 ` [PATCH 6/6] Werror: Provide a configuration option to enable -Werror David Howells
2008-05-29 18:30 ` Linus Torvalds
2008-05-29 18:29 ` [PATCH 1/6] Werror: Fix casting wrong size integer to pointer Linus Torvalds
2008-05-29 18:48 ` David Howells
2008-05-29 19:19 ` Andrew Morton
2008-05-29 19:25 ` David Howells
2008-05-29 20:08 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080529193513.0b6811b9@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox