From: David Brownell <david-b@pacbell.net>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: fix build errors for drivers not strictly requiring GPIOs
Date: Thu, 29 May 2008 20:28:10 -0700 [thread overview]
Message-ID: <200805292028.10906.david-b@pacbell.net> (raw)
In-Reply-To: <20080527142029.GA31778@polina.dev.rtsoft.ru>
On Tuesday 27 May 2008, Anton Vorontsov wrote:
> Since commit 7560fa60fcdcdb0da662f6a9fad9064b554ef46c (gpio: <linux/gpio.h>
> and "no GPIO support here" stubs) drivers can use GPIOs if they're available,
> but don't require them.
>
> This patch actually enables this feature, otherwise drivers will stumble
> against this:
>
> include/asm-generic/gpio.h:111: error: redefinition of 'gpio_is_valid'
> include/linux/gpio.h:21: error: previous definition of 'gpio_is_valid' was here
This looks to me like pure user error ... what was anyone doing
including <asm-generic/gpio.h> in that way? There are a *lot* of
bogus include combinations, and we don't try to "fix" them.
It should suffice to #include <linux/gpio.h> ... that causes the
definition of either (a) stubs in that file, *OR* else (b) the
platform-specific implementation of the GPIO calls, which may
(if that platform chooses) use <asm-generic/gpio.h> utilities.
NAK on this patch.
- dave
next prev parent reply other threads:[~2008-05-30 4:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 14:20 [PATCH] gpio: fix build errors for drivers not strictly requiring GPIOs Anton Vorontsov
2008-05-30 3:28 ` David Brownell [this message]
2008-05-30 12:06 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805292028.10906.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=avorontsov@ru.mvista.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox