Re: [RFC] [PATCH 1/2] cpusets: restructure the function update_cpumask() and update_nodemask()

Randy Dunlap
2008-05-30T03:17:19Z

On Thu, 29 May 2008 21:22:11 -0500 Paul Jackson wrote:

> Miao wrote:
> > I check kernel/cpuset.c and find many static functions with "/**" comment.
> > So I want to remove the special commenting convention for them.
>
> Right you are. Offhand, in kernel/cpuset.c, I see:
>
> static int cpuset_test_cpumask(struct task_struct *tsk,
> static void cpuset_change_cpumask(struct task_struct *tsk,
> static int update_cpumask(struct cpuset *cs, char *buf)
> static void cpuset_do_move_task(struct task_struct *tsk,
> static void move_member_tasks_to_cpuset(struct cpuset *from, struct cpuset *to)
>
> all having "/**" header comments. I would be glad to Ack a patch
> from you to fix such comments. Thank-you.

Uh.. We strongly want non-static functions to be documented via kernel-doc.
For static functions, it's up to the maintainer/developer whether to do that
or not. But if the functions already have kernel-doc, there's no strong
reason to remove it. And these look good currently, so I see no
good reason to change them.

---
~Randy
"He closes his eyes and drops the goggles. You can't get hurt
by looking at a bitmap. Or can you?"