Re: [GIT PATCH] USB fixes for 2.6.26-rc4

[Greg KH <gregkh@suse.de>]

On Thu, May 29, 2008 at 11:27:45PM +0200, Laurent Pinchart wrote:
> Hi Greg,
> 
> On Thursday 29 May 2008, Greg KH wrote:
> > Matthew Garrett (1):
> >       USB: Firmware loader driver for USB Apple iSight camera
> 
> Sorry not to have spotted this sooner, but I don't like this one. Why do we 
> need a specific kernel driver when a userspace tool (fxload) exists to 
> perform the same task, especially when the tool handles udev integration 
> nicely ? The Apple iSight uses an EZ-USB chipset. If we really want a kernel 
> driver for that it should probably be made more generic to handle all 
> EZ-USB-based devices.

Well, perhaps because no one did this kind of integration before?  :)

I'll take this driver out later, if the infrastructure is put into
place, and some kind of driver package is created for the distros to use
to implement this.

But until then, the easiest way to get this hardware working for users
is a tiny kernel firmware loader just like this one.  If you think we
should turn it into something for all ezusb devices, that's also a
possiblity.

thanks,

greg k-h