From: Paul Jackson <pj@sgi.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: miaox@cn.fujitsu.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, menage@google.com
Subject: Re: [PATCH 2/3] cpusets: restructure the function update_cpumask() and update_nodemask()
Date: Fri, 30 May 2008 10:56:58 -0500 [thread overview]
Message-ID: <20080530105658.1b2f4839.pj@sgi.com> (raw)
In-Reply-To: <20080530105302.0f447003@core>
Alan wrote:
> Trivial only: The kernel-doc bits should be /**, 3 of them.
It took me a minute to parse this comment (pre-coffee morning fog ;).
I take it that you're noticing, Alan, that the header comments for
the functions update_tasks_cpumask() and update_tasks_nodemask(), and
perhaps one other function, are already in kernel-doc format, except
for one detail -- they currently open with '/*' instead of '/**',
and you're recommending the trivial change '/*' ==> '/**' for these
cases.
Yes - Miao commented these new functions in kernel-doc format, all but
the '/**', by my request, which now stands NAQ'd.
So, yes, '/**' should be used on any kernel/cpuset.c function comment
that is otherwise already in kernel-doc format.
Again, thank-you.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.940.382.4214
prev parent reply other threads:[~2008-05-30 15:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 7:34 [PATCH 2/3] cpusets: restructure the function update_cpumask() and update_nodemask() Miao Xie
2008-05-30 9:53 ` Alan Cox
2008-05-30 15:56 ` Paul Jackson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080530105658.1b2f4839.pj@sgi.com \
--to=pj@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=miaox@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox