From: Matthias Kaehlcke <matthias@kaehlcke.net>
To: dwmw2@infradead.org, linux-mtd@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [patch 1/2] MTD: use list_for_each_entry() in add_mtd_device()
Date: Sat, 31 May 2008 15:35:11 +0200 [thread overview]
Message-ID: <20080531133511.GA8734@traven> (raw)
In-Reply-To: <20080531132808.984625508@kaehlcke.net>
sorry, i forgot to tell quilt to refresh the patch, here comes the
good one
--
MTD: use list_for_each_entry() instead of list_for_each() in add_mtd_device()
Signed-off-by: Matthias Kaehlcke <matthias@kaehlcke.net>
Index: linux-2.6/drivers/mtd/mtdcore.c
===================================================================
--- linux-2.6.orig/drivers/mtd/mtdcore.c 2008-05-31
15:31:17.000000000 +0200
+++ linux-2.6/drivers/mtd/mtdcore.c 2008-05-31 15:32:19.000000000
+0200
@@ -53,7 +53,7 @@
for (i=0; i < MAX_MTD_DEVICES; i++)
if (!mtd_table[i]) {
- struct list_head *this;
+ struct mtd_notifier *not;
mtd_table[i] = mtd;
mtd->index = i;
@@ -72,8 +72,7 @@
DEBUG(0, "mtd: Giving out device %d to
%s\n",i, mtd->name);
/* No need to get a refcount on the module
containing
the notifier, since we hold the
mtd_table_mutex */
- list_for_each(this, &mtd_notifiers) {
- struct mtd_notifier *not =
list_entry(this, struct mtd_notifier, list);
+ list_for_each_entry(not, &mtd_notifiers, list)
{
not->add(mtd);
}
--
Matthias Kaehlcke
Embedded Linux Engineer
Barcelona
I am incapable of conceiving infinity, and yet I do not accept finity
(Simone de Beauvoir)
.''`.
using free software / Debian GNU/Linux | http://debian.org : :' :
`. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-
next prev parent reply other threads:[~2008-05-31 13:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-31 13:28 [patch 0/2] MTD: use list_for_each_entry() matthias
2008-05-31 13:28 ` [patch 1/2] MTD: use list_for_each_entry() in add_mtd_device() matthias
2008-05-31 13:35 ` Matthias Kaehlcke [this message]
2008-05-31 19:41 ` Jörn Engel
2008-06-01 5:09 ` Matthias Kaehlcke
2008-06-04 16:34 ` David Woodhouse
2008-06-04 16:38 ` Matthias Kaehlcke
2008-05-31 13:28 ` [patch 2/2] MTD: use list_for_each_entry() in del_mtd_device() matthias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080531133511.GA8734@traven \
--to=matthias@kaehlcke.net \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox