From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754637AbYEaRqE (ORCPT ); Sat, 31 May 2008 13:46:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751706AbYEaRpx (ORCPT ); Sat, 31 May 2008 13:45:53 -0400 Received: from cantor.suse.de ([195.135.220.2]:36100 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751455AbYEaRpx (ORCPT ); Sat, 31 May 2008 13:45:53 -0400 Date: Sat, 31 May 2008 10:41:13 -0700 From: Greg KH To: Dave Jones , linux-kernel@vger.kernel.org Subject: Re: via agp patches Message-ID: <20080531174113.GA18996@suse.de> References: <20080531003214.GA6208@suse.de> <20080531003250.GB6208@suse.de> <20080531144715.GA22616@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080531144715.GA22616@redhat.com> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 31, 2008 at 10:47:15AM -0400, Dave Jones wrote: > On Fri, May 30, 2008 at 05:32:50PM -0700, Greg KH wrote: > > > > Looks like this adds a new device id, I have no idea why they remove > > another one at the same time... > > I sent a patch adding the missing ident to airlied a few weeks back. > I think it's currently in -mm. Great. > The removal of the other id is a mystery to me. Here's what I got back from Via about this: VT3336 is a chipset for AMD Athlon/K8 CPU. Due to K8's unique architecture, the AGP resource and behavior are different from the traditional AGP which resides only in chipset. AGP is used by 3D driver which wasn't available for the VT3336 and VT3364 generation until now. Unfortunately, by testing, VT3364 works but VT3336 doesn't. That is why the subtraction. I think other options are leaving it in the AGP, but removing it from our DRI driver. Or, just leave it in both but warn people for issues in the release note. So it sounds like it would be good to remove that id. thanks, greg k-h