From: Holger Macht <hmacht@suse.de>
To: Tejun Heo <htejun@gmail.com>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
Jeff Garzik <jeff@garzik.org>,
linux-acpi@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] libata: Handle bay devices in dock stations
Date: Sun, 1 Jun 2008 18:05:15 +0200 [thread overview]
Message-ID: <20080601160515.GA4599@homac> (raw)
In-Reply-To: <483EDC73.8030602@gmail.com>
On Fri 30. May - 01:40:19, Tejun Heo wrote:
> Holger Macht wrote:
> > On Thu 29. May - 15:49:34, Matthew Garrett wrote:
> >> Got it. It works if I lose the ata_port_freeze() from
> >> ata_acpi_detach_device.
> >
> > Tejun, any idea? This is in for quite some time now. Maybe there's some
> > involved...
>
> Does changing it to ata_port_schedule_eh() make any difference?
Finally found a system to reproduce the freeze...
And yes, removing ata_port_freeze() and only doing ata_port_schedule_eh()
in the case where the device has already gone works and prevents the
freeze. Also the docking case works. If this change is not only for
finding out what's going wrong, I'm going resend the patch with your
documentation additions, ok?
Regards,
Holger
next prev parent reply other threads:[~2008-06-01 16:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-28 14:38 [PATCH] libata: Handle bay devices in dock stations Holger Macht
2008-05-28 14:39 ` Tejun Heo
2008-05-29 3:02 ` Andrew Morton
2008-05-29 3:08 ` Tejun Heo
2008-05-29 13:22 ` Matthew Garrett
2008-05-29 13:33 ` Holger Macht
2008-05-29 13:32 ` Matthew Garrett
2008-05-29 13:39 ` Holger Macht
2008-05-29 13:40 ` Matthew Garrett
2008-05-29 13:44 ` Tejun Heo
2008-05-29 14:02 ` Matthew Garrett
2008-05-29 14:14 ` Holger Macht
2008-05-29 14:35 ` Matthew Garrett
2008-05-29 14:37 ` Tejun Heo
2008-05-29 14:49 ` Matthew Garrett
2008-05-29 16:32 ` Holger Macht
2008-05-29 16:40 ` Tejun Heo
2008-06-01 16:05 ` Holger Macht [this message]
2008-05-29 16:46 ` Holger Macht
2008-05-29 17:51 ` Henrique de Moraes Holschuh
2008-05-30 11:07 ` tom
2008-06-01 16:06 ` Holger Macht
2008-06-03 18:07 ` Jeff Garzik
2008-06-03 18:13 ` Matthew Garrett
2008-06-03 18:23 ` Holger Macht
2008-06-09 1:44 ` Tejun Heo
2008-06-09 1:48 ` Matthew Garrett
2008-06-09 4:56 ` Tejun Heo
2008-06-03 18:27 ` Holger Macht
2008-06-03 18:29 ` Matthew Garrett
2008-06-03 18:54 ` Jeff Garzik
2008-06-04 10:29 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2008-05-31 0:01 Pascal Brückner
2008-05-31 10:28 Pascal Brückner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080601160515.GA4599@homac \
--to=hmacht@suse.de \
--cc=akpm@linux-foundation.org \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox