Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB

Paul Mundt
2008-05-29T21:14:45Z

On Thu, May 29, 2008 at 04:21:05PM +0300, Pekka J Enberg wrote:
> On Thu, 29 May 2008, David Howells wrote:
> > ELF-FDPIC is currently using kobjsize() so that it can expand the heap/stack
> > segment to fill up the entirety of its allocation. It's probably worth
> > dropping that, though.
> >
> > NOMMU mmap() is using kobjsize()/ksize() to keep track of the number of bytes
> > allocated and the amount of dead space. We can probably ditch that too.
> >
> > However, fs/proc/task_nommu.c uses kobjsize() quite a bit to determine how
> > much metadata space a process is carrying around. We could just use sizeof(),
> > I suppose, and not bother calculating the slack.
>
> For short term, we should merge my two nommu patches as-is, no?

Not until the page->index bits are killed, otherwise you aren't fixing
anything. SLOB on nommu with those page->index tests will automatically
oops today, before or after your patches. Until that's resolved, there's
no point in pretending like kobjsize() has been "fixed". As no one has
come up with a valid reason for those tests existing in the first place,
simply having your patches and killing the BUG_ON()'s seems ok.

If we're not going to kill the BUG_ON()'s, then your patches are purely
cosmetic fixups with no behavioural change -- (ie, nommu is still hosed
on SLOB with current git).