Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB

Paul Mundt
2008-05-22T23:42:31Z

On Thu, May 22, 2008 at 07:09:04PM +0300, Pekka J Enberg wrote:
> Index: slab-2.6/mm/nommu.c
> ===================================================================
> --- slab-2.6.orig/mm/nommu.c 2008-05-22 18:59:01.000000000 +0300
> +++ slab-2.6/mm/nommu.c 2008-05-22 19:00:36.000000000 +0300
> @@ -109,12 +109,22 @@
> * If the object we have should not have ksize performed on it,
> * return size of 0
> */
> - if (!objp || (unsigned long)objp >= memory_end || !((page = virt_to_page(objp))))
> + if (!objp)
> + return 0;
> +
> + if ((unsigned long) objp >= memory_end)
> + return 0;
> +
> + page = virt_to_head_page(objp);
> + if (!page)
> return 0;
>
> if (PageSlab(page))
> return ksize(objp);
>
Is ksize() happy with taking the head page instead of virt_to_page(objp)?