Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB

Paul Mundt
2008-06-01T10:26:18Z

On Sun, Jun 01, 2008 at 12:13:02PM +0300, Pekka J Enberg wrote:
> Hi Paul,
>
> On Sun, 1 Jun 2008, Paul Mundt wrote:
> > This still needs to be virt_to_head_page() I think.
> >
> > I don't have my nommu boards at home, so I'll test at the office tomorow
> > morning and let you know.
>
> I was about to send a patch that fixes some of the kobjsize() abuses to
> use ksize() but then I realized that what we probably should do is
> something like this instead.
>
> I mean, assuming the BUG_ON bits are bogus, then we should always pass the
> pointer to the allocator. I audited most of the callers and they all seem
> to be really just using kmalloc() for allocation anyway.
>
> What do you think?
>
Isn't this what my original patch did? ;-)