From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758435AbYFBHDl (ORCPT ); Mon, 2 Jun 2008 03:03:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757390AbYFBHDY (ORCPT ); Mon, 2 Jun 2008 03:03:24 -0400 Received: from mta23.gyao.ne.jp ([125.63.38.249]:45723 "EHLO mx.gate01.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756384AbYFBHDX (ORCPT ); Mon, 2 Jun 2008 03:03:23 -0400 Date: Mon, 2 Jun 2008 16:01:05 +0900 From: Paul Mundt To: Pekka Enberg Cc: David Howells , Christoph Lameter , LKML , cooloney@kernel.org, akpm@linux-foundation.org, mpm@selenic.com Subject: Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB Message-ID: <20080602070105.GA28198@linux-sh.org> Mail-Followup-To: Paul Mundt , Pekka Enberg , David Howells , Christoph Lameter , LKML , cooloney@kernel.org, akpm@linux-foundation.org, mpm@selenic.com References: <20080601082427.GC25429@linux-sh.org> <20080601102401.GD25429@linux-sh.org> <48427A13.7050704@cs.helsinki.fi> <20080601112137.GE25429@linux-sh.org> <20080602055922.GA24626@linux-sh.org> <84144f020806012332n47ba7a7eg37a6892dbb059d09@mail.gmail.com> <20080602065055.GA27293@linux-sh.org> <84144f020806012358y6a2e5707odca7216a72e4092f@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <84144f020806012358y6a2e5707odca7216a72e4092f@mail.gmail.com> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 02, 2008 at 09:58:01AM +0300, Pekka Enberg wrote: > Hi Paul, > > On Mon, Jun 2, 2008 at 9:50 AM, Paul Mundt wrote: > > Well, with that modified version of your patch I posted, even if your > > previous PG_slab patches aren't applied, kobjsize() doesn't behave any > > worse than it presently does in terms of object size accuracy. > > > > In short: PG_slab doesn't get set and ksize() is never called, so we get > > the same degree of accuracy as the existing implementation, and the > > oopses get fixed (and the comments are still accurate, too!). So I think > > it's worth applying. Verified on all of SLUB/SLOB/SLAB. > > Agreed. Can you send this to Andrew? > > Reviewed-by: Pekka Enberg > Will do! > On Mon, Jun 2, 2008 at 9:50 AM, Paul Mundt wrote: > > As for the call-site question, perhaps I'm misunderstanding your > > question. alloc_vfsmnt() is the first to call kmem_cache_zalloc() during > > boot-up on my system, but I'm not sure what relevance this has to > > anything? Accurately measuring kmem_cache_alloc() and static allocations > > is going to need quite a bit more of a re-think, but that's out of scope > > for 2.6.26. Presently I'd rather have my system booting first :-) > > David already mentioned some (most?) of the kobjsize() calls can go > away and I think we should pursue that for 2.6.27. Ah, the kobjsize() calls is what you were getting at. Yes, getting rid of those would be a good plan. I'll start looking at that more in-depth once I've got some of my other 2.6.27 stuff out of the way. That's definitely one interface that needs to be killed off with extreme prejudice..