From: Andy Whitcroft <apw@shadowen.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Brownell <david-b@pacbell.net>,
linux-kernel@vger.kernel.org,
linux-pm@lists.linux-foundation.org, mingo@elte.hu,
pavel@suse.cz
Subject: Re: [patch 2.6.26-rc4-git] PM: boot time suspend selftest
Date: Tue, 3 Jun 2008 11:45:38 +0100 [thread overview]
Message-ID: <20080603104538.GQ27013@shadowen.org> (raw)
In-Reply-To: <20080529162257.03426e48.akpm@linux-foundation.org>
On Thu, May 29, 2008 at 04:22:57PM -0700, Andrew Morton wrote:
> > +static void __init test_wakealarm(struct rtc_device *rtc, suspend_state_t state)
> > +{
> > + static char err_readtime [] __initdata =
> > + KERN_ERR "PM: can't read %s time, err %d\n";
> > + static char err_wakealarm [] __initdata =
> > + KERN_ERR "PM: can't set %s wakealarm, err %d\n";
> > + static char err_suspend [] __initdata =
> > + KERN_ERR "PM: suspend test failed, error %d\n";
> > + static char info_test [] __initdata =
> > + KERN_INFO "PM: test RTC wakeup from '%s' suspend\n";
>
> - One tab before the variable space is a waste of space. Two tabs is
> just extravagant.
>
> - The space before the [] shouldn't be there. checkpatch misses this.
Ok, this should be picked up in the next release:
ERROR: space prohibited before open square bracket '['
#1: FILE: Z152.c:1:
+ static char info_test [] __initdata =
-apw
next prev parent reply other threads:[~2008-06-03 10:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 20:33 [patch 2.6.26-rc4-git] PM: boot time suspend selftest David Brownell
2008-05-29 21:01 ` Rafael J. Wysocki
2008-05-29 21:26 ` David Brownell
2008-05-29 21:29 ` Rafael J. Wysocki
2008-05-29 23:06 ` Andrew Morton
2008-05-30 4:34 ` David Brownell
2008-05-29 23:22 ` Andrew Morton
2008-05-30 10:59 ` Ingo Molnar
2008-05-30 19:04 ` Andrew Morton
2008-06-03 9:27 ` [PATCH] add a printk_init variant storing format strings in __initdata Andy Whitcroft
2008-06-03 16:41 ` Johannes Weiner
2008-06-03 17:49 ` [linux-pm] " Johannes Berg
2008-06-04 8:16 ` Andrew Morton
2008-06-04 8:32 ` MinChan Kim
2008-06-04 8:59 ` David Woodhouse
2008-06-04 9:10 ` [linux-pm] " Johannes Berg
2008-06-04 9:17 ` David Woodhouse
2008-06-04 10:51 ` Johannes Berg
2008-06-04 11:43 ` Alan Cox
2008-06-04 8:56 ` David Woodhouse
2008-06-03 10:45 ` Andy Whitcroft [this message]
2008-07-07 4:12 ` [patch 2.6.26-rc4-git] PM: boot time suspend selftest David Brownell
2008-07-23 8:19 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080603104538.GQ27013@shadowen.org \
--to=apw@shadowen.org \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mingo@elte.hu \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox