From: Andrew Morton <akpm@linux-foundation.org>
To: "Andrew Victor" <avictor.za@gmail.com>
Cc: wim@iguana.be, linux-arm-kernel@lists.arm.linux.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: AT91SAM9/CAP9 watchdog driver
Date: Tue, 3 Jun 2008 14:23:16 -0700 [thread overview]
Message-ID: <20080603142316.c53b32b2.akpm@linux-foundation.org> (raw)
In-Reply-To: <cd73a99e0806010940g501f11b4jcb7caf6acfd5c49f@mail.gmail.com>
On Sun, 1 Jun 2008 18:40:46 +0200
"Andrew Victor" <avictor.za@gmail.com> wrote:
> +static int __init at91wdt_probe(struct platform_device *pdev)
> +{
> + int res;
> +
> + if (at91wdt_miscdev.parent)
> + return -EBUSY;
> + at91wdt_miscdev.parent = &pdev->dev;
> +
> + res = misc_register(&at91wdt_miscdev);
> + if (res)
> + return res;
> +
> + /* Set watchdog */
> + if (at91_wdt_settimeout(wdt_timeout) == -EINVAL) {
> + pr_info("at91sam9_wdt: timeout must be between 1 and %d.\n",
> + WDT_MAX_TIME);
Would printk(KERN_ERR be more appropriate here?
> + return 0;
That looks like the wrong return value?
> + }
> +
> + return 0;
> +}
next prev parent reply other threads:[~2008-06-03 21:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-01 16:40 AT91SAM9/CAP9 watchdog driver Andrew Victor
2008-06-02 6:58 ` Alan Cox
2008-06-03 21:23 ` Andrew Morton [this message]
2008-06-04 7:31 ` Andrew Victor
2008-06-04 11:36 ` Alan Cox
2008-06-04 18:36 ` Andrew Victor
2008-06-04 18:24 ` Alan Cox
2008-06-04 19:02 ` Andrew Victor
2008-06-04 19:18 ` Alan Cox
2008-06-07 6:39 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080603142316.c53b32b2.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=avictor.za@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox