From: Robert Richter <robert.richter@amd.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Andi Kleen <andi@firstfloor.org>,
Arjan van de Ven <arjan@infradead.org>
Subject: [PATCH] fix build bug in "x86: add PCI extended config space access for AMD Barcelona"
Date: Tue, 3 Jun 2008 19:37:04 +0200 [thread overview]
Message-ID: <20080603173705.1790F8316@erda.amd.com> (raw)
In-Reply-To: <20080602143830.GA6835@elte.hu>
Signed-off-by: Robert Richter <robert.richter@amd.com>
---
arch/powerpc/kernel/setup_64.c | 2 --
arch/x86/kernel/cpu/amd.c | 1 -
arch/x86/kernel/cpu/amd_64.c | 1 +
arch/x86/kernel/setup.c | 4 ++--
include/asm-x86/mmconfig.h | 6 ------
5 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
index 098fd96..3a193a9 100644
--- a/arch/powerpc/kernel/setup_64.c
+++ b/arch/powerpc/kernel/setup_64.c
@@ -62,8 +62,6 @@
#include <asm/udbg.h>
#include <asm/kexec.h>
-#include "setup.h"
-
#ifdef DEBUG
#define DBG(fmt...) udbg_printf(fmt)
#else
diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
index 656b40a..99221f9 100644
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -4,7 +4,6 @@
#include <asm/io.h>
#include <asm/processor.h>
#include <asm/apic.h>
-#include <asm/mmconfig.h>
#include <mach_apic.h>
#include "../setup.h"
diff --git a/arch/x86/kernel/cpu/amd_64.c b/arch/x86/kernel/cpu/amd_64.c
index 180097e..6c63496 100644
--- a/arch/x86/kernel/cpu/amd_64.c
+++ b/arch/x86/kernel/cpu/amd_64.c
@@ -6,6 +6,7 @@
#include <asm/cacheflush.h>
#include <mach_apic.h>
+#include "../setup.h"
extern int __cpuinit get_model_name(struct cpuinfo_x86 *c);
extern void __cpuinit display_cacheinfo(struct cpuinfo_x86 *c);
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 549e6e6..a7185ac 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -204,6 +204,8 @@ void __init setup_per_cpu_areas(void)
setup_cpumask_of_cpu();
}
+#endif
+
#define ENABLE_CF8_EXT_CFG (1ULL << 46)
void __cpuinit amd_enable_pci_ext_cfg(struct cpuinfo_x86 *c)
@@ -217,8 +219,6 @@ void __cpuinit amd_enable_pci_ext_cfg(struct cpuinfo_x86 *c)
set_cpu_cap(c, X86_FEATURE_PCI_EXT_CFG);
}
-#endif
-
#ifdef X86_64_NUMA
/*
diff --git a/include/asm-x86/mmconfig.h b/include/asm-x86/mmconfig.h
index 691798f..95beda0 100644
--- a/include/asm-x86/mmconfig.h
+++ b/include/asm-x86/mmconfig.h
@@ -9,10 +9,4 @@ static inline void fam10h_check_enable_mmcfg(void) { }
static inline void check_enable_amd_mmconf_dmi(void) { }
#endif
-#if defined(CONFIG_SMP) && defined(CONFIG_X86_64)
-extern void __cpuinit amd_enable_pci_ext_cfg(struct cpuinfo_x86 *c);
-#else
-static inline void amd_enable_pci_ext_cfg(struct cpuinfo_x86 *c) { }
-#endif
-
#endif
--
1.5.5.1
next parent reply other threads:[~2008-06-03 17:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080602143830.GA6835@elte.hu>
2008-06-03 17:37 ` Robert Richter [this message]
2008-06-04 15:11 ` [PATCH] fix build bug in "x86: add PCI extended config space access for AMD Barcelona" Robert Richter
2008-06-05 17:32 ` Robert Richter
2008-06-05 20:41 ` Thomas Gleixner
2008-06-06 10:01 ` [PATCH] fix build bug in "x86: add PCI extended config space access for AMD Barcelona" (try #3) Robert Richter
2008-06-10 10:33 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080603173705.1790F8316@erda.amd.com \
--to=robert.richter@amd.com \
--cc=andi@firstfloor.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox