public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Dike <jdike@addtoit.com>
To: Andrew Morton <akpm@osdl.org>,
	LKML <linux-kernel@vger.kernel.org>,
	uml-devel <user-mode-linux-devel@lists.sourceforge.net>
Cc: Nix <nix@esperi.org.uk>
Subject: [PATCH 1/6] UML - Deal with host time going backwards
Date: Tue, 3 Jun 2008 15:02:35 -0400	[thread overview]
Message-ID: <20080603190235.GA9511@c2.user-mode-linux.org> (raw)

Protection against the host's time going backwards - keep track of the
time at the last tick and if it's greater than the current time, keep
time stopped until the host catches up.

Cc: Nix <nix@esperi.org.uk>
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
---
 arch/um/os-Linux/time.c |    7 +++++++
 1 file changed, 7 insertions(+)

Index: linux-2.6-git/arch/um/os-Linux/time.c
===================================================================
--- linux-2.6-git.orig/arch/um/os-Linux/time.c	2008-05-14 10:44:02.000000000 -0400
+++ linux-2.6-git/arch/um/os-Linux/time.c	2008-06-02 15:43:53.000000000 -0400
@@ -106,6 +106,10 @@ static void deliver_alarm(void)
 	unsigned long long this_tick = os_nsecs();
 	int one_tick = UM_NSEC_PER_SEC / UM_HZ;
 
+	/* Protection against the host's time going backwards */
+	if ((last_tick != 0) && (this_tick < last_tick))
+		this_tick = last_tick;
+
 	if (last_tick == 0)
 		last_tick = this_tick - one_tick;
 
@@ -148,6 +152,9 @@ static int after_sleep_interval(struct t
 		start_usecs = usec;
 
 	start_usecs -= skew / UM_NSEC_PER_USEC;
+	if (start_usecs < 0)
+		start_usecs = 0;
+
 	tv = ((struct timeval) { .tv_sec  = start_usecs / UM_USEC_PER_SEC,
 				 .tv_usec = start_usecs % UM_USEC_PER_SEC });
 	interval = ((struct itimerval) { { 0, usec }, tv });

             reply	other threads:[~2008-06-03 19:05 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-03 19:02 Jeff Dike [this message]
2008-06-03 19:32 ` [PATCH 1/6] UML - Deal with host time going backwards Andrew Morton
2008-06-03 19:43   ` Daniel Hazelton
2008-06-03 19:52     ` Nix
2008-06-03 20:07       ` Andrew Morton
2008-06-03 20:37         ` Daniel Hazelton
2008-06-03 21:00         ` Jeff Dike
2008-06-04  1:50           ` Eric W. Biederman
2008-06-04  3:15             ` Jeff Dike
2008-06-04  5:12             ` Daniel Hazelton
2008-06-04 14:31           ` Jeremy Fitzhardinge
2008-06-04 19:37             ` Jeff Dike
2008-06-04 20:05               ` Jeremy Fitzhardinge
2008-06-05 15:30                 ` Jeff Dike
2008-06-05 18:14                   ` Nix
2008-06-05 19:47                     ` Jeff Dike
2008-06-05 21:41                       ` Nix
2008-06-05 18:19                   ` Nix
  -- strict thread matches above, loose matches on Subject: below --
2008-06-03 19:59 devzero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080603190235.GA9511@c2.user-mode-linux.org \
    --to=jdike@addtoit.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nix@esperi.org.uk \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox