From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
Virtualization Mailing List <virtualization@lists.osdl.org>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Rusty Russell <rusty@rustcorp.com.au>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 2/3] virtio_console: use virtqueue notification for hvc_console
Date: Tue, 3 Jun 2008 19:24:41 +0200 [thread overview]
Message-ID: <200806031924.42464.arnd@arndb.de> (raw)
In-Reply-To: <200806031446.15330.borntraeger@de.ibm.com>
On Tuesday 03 June 2008, Christian Borntraeger wrote:
>
> +/* The hvc device */
> +struct hvc_struct *hvc;
> +
I guess this should be static, a three letter identifier for a global variable
is not really unique.
Arnd <><
next prev parent reply other threads:[~2008-06-03 17:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-03 12:44 [RFC 0/3]: hvc_console rework for platform without hard irqs Christian Borntraeger
2008-06-03 12:45 ` [RFC 1/3] hvc_console: rework setup to replace irq functions with callbacks Christian Borntraeger
2008-06-04 0:13 ` Rusty Russell
2008-06-04 11:15 ` Christian Borntraeger
2008-10-13 5:16 ` Benjamin Herrenschmidt
2008-10-13 7:51 ` Christian Borntraeger
2008-10-13 8:36 ` Benjamin Herrenschmidt
2008-10-13 8:47 ` Christian Borntraeger
2008-10-13 9:52 ` Benjamin Herrenschmidt
2008-10-14 0:38 ` Benjamin Herrenschmidt
2008-10-14 6:42 ` Christian Borntraeger
2008-10-14 8:18 ` Benjamin Herrenschmidt
2008-06-03 12:46 ` [RFC 2/3] virtio_console: use virtqueue notification for hvc_console Christian Borntraeger
2008-06-03 17:24 ` Arnd Bergmann [this message]
2008-06-03 12:46 ` [RFC 3/3] s390: use virtio_console for KVM on s390 Christian Borntraeger
2008-06-03 12:49 ` [RFC 1/3] hvc_console: rework setup to replace irq functions with callbacks (not word wrapped) Christian Borntraeger
2008-06-03 17:30 ` Arnd Bergmann
2008-06-04 8:00 ` Christian Borntraeger
2008-06-04 9:06 ` Benjamin Herrenschmidt
2008-06-20 13:24 ` [RFC 1/3 v2] hvc_console: rework setup to replace irq functions with callbacks Christian Borntraeger
2008-06-27 5:27 ` Rusty Russell
2008-06-20 13:24 ` [RFC 2/3 v2] virtio_console: use virtqueue notification for hvc_console Christian Borntraeger
2008-06-20 13:24 ` [RFC 3/3 v2] s390: use virtio_console for KVM on s390 Christian Borntraeger
2008-06-23 3:04 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806031924.42464.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=borntraeger@de.ibm.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox