public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Glauber Costa <gcosta@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	tglx@linutronix.de, Yinghai Lu <yhlu.kernel@gmail.com>
Subject: Re: [PATCH] Make x86 latest boot with non-discontig boxes
Date: Wed, 4 Jun 2008 12:36:37 +0200	[thread overview]
Message-ID: <20080604103637.GA2837@elte.hu> (raw)
In-Reply-To: <1212552507-15134-1-git-send-email-gcosta@redhat.com>


* Glauber Costa <gcosta@redhat.com> wrote:

> Commit 0596152388e234efebce464355186ad9e16c8cb6 broke my box, since it 
> removes completely the call to memory_present() at e820 setup.
> 
> It seems to be really not needed with discontig memory, but with flat 
> and sparse, I get an early crash. The proposed patch moves the call 
> memory_present() to setup_memory, the one present in setup_32.c.

thanks for tracking it down. Could you check whether the latest 
x86/master tree works fine now?

	Ingo

  parent reply	other threads:[~2008-06-04 10:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-04  4:08 [PATCH] Make x86 latest boot with non-discontig boxes Glauber Costa
2008-06-04  4:51 ` Yinghai Lu
2008-06-04  5:20   ` Glauber Costa
2008-06-04  6:26     ` Yinghai Lu
2008-06-04 10:36 ` Ingo Molnar [this message]
2008-06-04 13:21   ` Glauber Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080604103637.GA2837@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=gcosta@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox