public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [patch -v3 18/22] zorro: use memory_read_from_buffer
Date: Wed, 04 Jun 2008 20:56:51 +0900	[thread overview]
Message-ID: <20080604115835.346945584@gmail.com> (raw)
In-Reply-To: 20080604115633.116832712@gmail.com

[-- Attachment #1: zorro-use-memory-read-from-buffer.patch --]
[-- Type: text/plain, Size: 1232 bytes --]

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/zorro/zorro-sysfs.c |   10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

Index: 2.6-git/drivers/zorro/zorro-sysfs.c
===================================================================
--- 2.6-git.orig/drivers/zorro/zorro-sysfs.c
+++ 2.6-git/drivers/zorro/zorro-sysfs.c
@@ -15,6 +15,7 @@
 #include <linux/zorro.h>
 #include <linux/stat.h>
 #include <linux/string.h>
+#include <linux/fs.h>
 
 #include "zorro.h"
 
@@ -56,12 +57,6 @@ static ssize_t zorro_read_config(struct 
 	struct zorro_dev *z = to_zorro_dev(container_of(kobj, struct device,
 					   kobj));
 	struct ConfigDev cd;
-	unsigned int size = sizeof(cd);
-
-	if (off > size)
-		return 0;
-	if (off+count > size)
-		count = size-off;
 
 	/* Construct a ConfigDev */
 	memset(&cd, 0, sizeof(cd));
@@ -71,8 +66,7 @@ static ssize_t zorro_read_config(struct 
 	cd.cd_BoardAddr = (void *)zorro_resource_start(z);
 	cd.cd_BoardSize = zorro_resource_len(z);
 
-	memcpy(buf, (void *)&cd+off, count);
-	return count;
+	return memory_read_from_buffer(buf, count, &off, &cd, sizeof(cd));
 }
 
 static struct bin_attribute zorro_config_attr = {

-- 

  parent reply	other threads:[~2008-06-04 12:16 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-04 11:56 [patch -v3 00/22] use simple_read_from_buffer and memory_read_from_buffer Akinobu Mita
2008-06-04 11:56 ` [patch -v3 01/22] binfmt_misc: use simple_read_from_buffer Akinobu Mita
2008-06-04 11:56 ` [patch -v3 02/22] ocfs2: " Akinobu Mita
2008-06-06 22:46   ` Joel Becker
2008-06-04 11:56 ` [patch -v3 03/22] ipc: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 04/22] isdn: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 05/22] s390/vmcp: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 06/22] s390: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 07/22] nwflash: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 08/22] usbmon: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 09/22] ttusb: use simple_read_from_buffer() Akinobu Mita
2008-06-04 11:56 ` [patch -v3 10/22] airo: use simple_read_from_buffer Akinobu Mita
2008-06-04 11:56 ` [patch -v3 11/22] cris: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 12/22] introduce memory_read_from_buffer Akinobu Mita
2008-06-04 11:56 ` [patch -v3 13/22] dcdbas: use memory_read_from_buffer Akinobu Mita
2008-06-04 11:56 ` [patch -v3 14/22] dell_rbu: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 15/22] firmware: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 16/22] acpi: " Akinobu Mita
2008-06-05  1:21   ` Zhao Yakui
2008-06-05  1:29     ` Andrew Morton
2008-06-04 11:56 ` [patch -v3 17/22] aty: " Akinobu Mita
2008-06-04 11:56 ` Akinobu Mita [this message]
2008-06-04 11:56 ` [patch -v3 19/22] s390/cio: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 20/22] s390: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 21/22] ipr: " Akinobu Mita
2008-06-04 11:56 ` [patch -v3 22/22] qla2xxx: " Akinobu Mita
2008-06-06 17:06   ` Andrew Vasquez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080604115835.346945584@gmail.com \
    --to=akinobu.mita@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox