From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Andrew Victor" <avictor.za@gmail.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
wim@iguana.be, linux-arm-kernel@lists.arm.linux.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: AT91SAM9/CAP9 watchdog driver
Date: Wed, 4 Jun 2008 12:36:42 +0100 [thread overview]
Message-ID: <20080604123642.51449a04@core> (raw)
In-Reply-To: <cd73a99e0806040031s13e6b4a5ndc5fb3d931e1945f@mail.gmail.com>
On Wed, 4 Jun 2008 09:31:50 +0200
"Andrew Victor" <avictor.za@gmail.com> wrote:
> hi Andrew,
>
> >> + return 0;
> >
> > That looks like the wrong return value?
>
> Since the watchdog registers are Write-Once, if the user does not
> specify a "wdt_timeout" parameter we'd still like the driver to load
> even if it's not enabled.
Surely you can avoid doing the register writes until after you check the
validity of arguments ?
next prev parent reply other threads:[~2008-06-04 11:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-01 16:40 AT91SAM9/CAP9 watchdog driver Andrew Victor
2008-06-02 6:58 ` Alan Cox
2008-06-03 21:23 ` Andrew Morton
2008-06-04 7:31 ` Andrew Victor
2008-06-04 11:36 ` Alan Cox [this message]
2008-06-04 18:36 ` Andrew Victor
2008-06-04 18:24 ` Alan Cox
2008-06-04 19:02 ` Andrew Victor
2008-06-04 19:18 ` Alan Cox
2008-06-07 6:39 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080604123642.51449a04@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=avictor.za@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox