From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761168AbYFDRg6 (ORCPT ); Wed, 4 Jun 2008 13:36:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755409AbYFDRgv (ORCPT ); Wed, 4 Jun 2008 13:36:51 -0400 Received: from palinux.external.hp.com ([192.25.206.14]:58964 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755372AbYFDRgu (ORCPT ); Wed, 4 Jun 2008 13:36:50 -0400 Date: Wed, 4 Jun 2008 11:36:34 -0600 From: Matthew Wilcox To: Oleg Nesterov Cc: Andrew Morton , Ingo Molnar , Dmitry Adamushko , Peter Zijlstra , Roland McGrath , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] __down_common: use signal_pending_state() Message-ID: <20080604173633.GI3549@parisc-linux.org> References: <20080604170906.GA10276@tv-sign.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080604170906.GA10276@tv-sign.ru> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 04, 2008 at 09:09:06PM +0400, Oleg Nesterov wrote: > Cleanup. __down_common() can use the new signal_pending_state() helper. This is a bad optimisation. __down_common gets inlined and the constant 'state' versions are optimised away for the versions which don't apply. NAK this patch. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."