From: Andrew Morton <akpm@linux-foundation.org>
To: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
Cc: tigran@aivazian.fsnet.co.uk, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 0/2] Remove BKL from the bfs driver
Date: Thu, 5 Jun 2008 11:42:13 -0700 [thread overview]
Message-ID: <20080605114213.239d66aa.akpm@linux-foundation.org> (raw)
In-Reply-To: <1212690397-25693-1-git-send-email-dmitri.vorobiev@movial.fi>
On Thu, 5 Jun 2008 21:26:35 +0300
Dmitri Vorobiev <dmitri.vorobiev@movial.fi> wrote:
> This removes quite a few instances of BKL usage in the bfs
> driver. Given the purpose and the user base of this driver,
> I do not believe that a finer-granularity lock than the big
> fat filesystem-wide mutex I have implemented here is needed.
How well tested was this? With lockdep enabled?
Because the new mutex cannot be taken recursively, whereas the BKL can.
And there's potential for ab/ba deadlocks with, for example, i_mutex.
However I don't see any such problems from a moderately intensive
review.
next prev parent reply other threads:[~2008-06-05 18:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 18:26 [PATCH 0/2] Remove BKL from the bfs driver Dmitri Vorobiev
2008-06-05 18:26 ` [PATCH 1/2] bfs: assorted cleanups Dmitri Vorobiev
2008-06-05 18:26 ` [PATCH 2/2] bfs: kill BKL Dmitri Vorobiev
2008-06-05 18:42 ` Andrew Morton [this message]
2008-06-05 21:11 ` [PATCH 0/2] Remove BKL from the bfs driver Vorobiev Dmitri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080605114213.239d66aa.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dmitri.vorobiev@movial.fi \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tigran@aivazian.fsnet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox