From: "Serge E. Hallyn" <serue@us.ibm.com>
To: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: Pavel Emelyanov <xemul@openvz.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] devscgroup: make white list more compact in some cases
Date: Thu, 5 Jun 2008 14:16:47 -0500 [thread overview]
Message-ID: <20080605191647.GA27304@us.ibm.com> (raw)
In-Reply-To: <20080605142338.GB11919@us.ibm.com>
Quoting Serge E. Hallyn (serue@us.ibm.com):
> Quoting Pavel Emelyanov (xemul@openvz.org):
> > Consider you added a 'c foo:bar r' permission to some cgroup and then
> > (a bit later) 'c'foo:bar w' for it. After this you'll see a
> > c foo:bar r
> > c foo:bar w
> > lines in a devices.list file.
> >
> > Another example - consider you added 10 'c foo:bar r' permissions to
> > some cgroup (e.g. by mistake). After this you'll see 10
> > c foo:bar r
> > lines in a list file.
> >
> > This is weird. This situation also has one more annoying consequence.
> > Having many items in a white list makes permissions checking slower,
> > sine it has to walk a longer list.
> >
> > The proposal is to merge permissions for items, that correspond to the
> > same device.
> >
> > Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
>
> Acked-by: Serge Hallyn <serue@us.ibm.com>
>
> Thanks. I suppose if it was deemed worth it, the other thing you could
> do would be to detect when you have a rule
>
> c foo:bar r
>
> and you add a rule
>
> c foo:(all) r
But a private email response preferred the each-entry-is-separate
semantics, so I retract that suggestion.
-serge
prev parent reply other threads:[~2008-06-05 19:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 8:45 [PATCH 2/2] devscgroup: make white list more compact in some cases Pavel Emelyanov
2008-06-05 14:23 ` Serge E. Hallyn
2008-06-05 19:16 ` Serge E. Hallyn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080605191647.GA27304@us.ibm.com \
--to=serue@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox