From: Scott Wiersdorf <scott@perlcode.org>
To: Balbir Singh <balbir@in.ibm.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
matt@bluehost.com
Subject: [PATCH 2.6.25-4] getdelays.c: signal handling for log rotation
Date: Thu, 5 Jun 2008 13:43:35 -0600 [thread overview]
Message-ID: <20080605194334.GA56830@perlcode.org> (raw)
This adds a USR1 signal handler to getdelays.c, which causes getdelays
to close its logfile and reopen it (if '-w logfile' is
specified). This is useful in situations when getdelays is running for
a long time (i.e, the log file growing) and you need to rotate the
logs but don't want to lose any log data.
Signed-off-by: Scott Wiersdorf <scott@perlcode.org>
---
--- Documentation/accounting/getdelays.c 2008-05-15 09:00:12.000000000 -0600
+++ Documentation/accounting/getdelays.c 2008-06-05 02:23:57.000000000 -0600
@@ -50,6 +50,7 @@ int dbg;
int print_delays;
int print_io_accounting;
int print_task_context_switch_counts;
+volatile sig_atomic_t reopen_log = 0;
__u64 stime, utime;
#define PRINTF(fmt, arg...) { \
@@ -80,6 +81,7 @@ static void usage(void)
fprintf(stderr, " -l: listen forever\n");
fprintf(stderr, " -v: debug on\n");
fprintf(stderr, " -C: container path\n");
+ fprintf(stderr, "\nSend USR1 to reopen the logfile if -w is used.\n");
}
/*
@@ -231,6 +233,30 @@ void print_ioacct(struct taskstats *t)
(unsigned long long)t->cancelled_write_bytes);
}
+void catch_usr1(int sig)
+{
+ reopen_log = 1;
+ signal(sig, catch_usr1);
+}
+
+int reopen_logfile(int fd, char *logfile)
+{
+ if (fd) {
+ PRINTF("USR1 received. Closing logfile.\n");
+ close(fd);
+ }
+ fd = open(logfile, O_WRONLY | O_CREAT | O_TRUNC,
+ S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
+ if (fd == -1) {
+ perror("Cannot open output file\n");
+ exit(1);
+ }
+
+ reopen_log = 0;
+
+ return fd;
+}
+
int main(int argc, char *argv[])
{
int c, rc, rep_len, aggr_len, len2, cmd_type;
@@ -320,12 +346,8 @@ int main(int argc, char *argv[])
}
if (write_file) {
- fd = open(logfile, O_WRONLY | O_CREAT | O_TRUNC,
- S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
- if (fd == -1) {
- perror("Cannot open output file\n");
- exit(1);
- }
+ fd = reopen_logfile(fd, logfile);
+ signal(SIGUSR1, catch_usr1); /* only set when write_file is set */
}
if ((nl_sd = create_nl_socket(NETLINK_GENERIC)) < 0)
@@ -444,6 +466,9 @@ int main(int argc, char *argv[])
err(1,"write error\n");
}
}
+ if (reopen_log) {
+ fd = reopen_logfile(fd, logfile);
+ }
if (!loop)
goto done;
break;
next reply other threads:[~2008-06-05 20:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 19:43 Scott Wiersdorf [this message]
2008-06-06 3:46 ` [PATCH 2.6.25-4] getdelays.c: signal handling for log rotation Balbir Singh
2008-06-06 20:40 ` Scott Wiersdorf
2008-06-06 13:59 ` Andi Kleen
2008-06-06 20:42 ` Scott Wiersdorf
2008-06-07 1:10 ` Andi Kleen
2008-06-06 20:47 ` Scott Wiersdorf
2008-06-07 1:13 ` Andi Kleen
2008-06-09 14:20 ` Scott Wiersdorf
2008-06-09 14:42 ` Balbir Singh
2008-06-30 19:52 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080605194334.GA56830@perlcode.org \
--to=scott@perlcode.org \
--cc=akpm@linux-foundation.org \
--cc=balbir@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@bluehost.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox