public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Hinko Kočevar" <hinko.kocevar@cetrtapot.si>
Cc: linux-kernel@vger.kernel.org, dev-etrax@axis.com
Subject: Re: [PATCH 2.6.26-rc5 1/2] cris: compile fixes for 2.6.26-rc5
Date: Fri, 6 Jun 2008 12:41:49 +0100	[thread overview]
Message-ID: <20080606124149.2d87f980@core> (raw)
In-Reply-To: <4849218D.7080306@cetrtapot.si>

> +static struct tty_operations dummy_ops = {
> +	.open = &dummy_open,
> +	.close = &dummy_close,
> +	.write = &dummy_write,
> +	.write_room = &dummy_write_room,
> +};

Looks ok. From 2.6.26 onward you should be able to omit write/write_room
if you want writes to error, but you will need the dummies if you want
them to vanish.

> @@ -448,10 +455,7 @@ init_dummy_console(void)
>  		B115200 | CS8 | CREAD | HUPCL | CLOCAL; /* is normally B9600 default... */

It should also be setting c_ispeed/c_ospeed

>  	dummy_driver.flags = TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV;

Alan

  reply	other threads:[~2008-06-06 11:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-06 11:36 [PATCH 2.6.26-rc5 0/2] cris: compile fixes for 2.6.26-rc5 Hinko Kočevar
2008-06-06 11:37 ` [PATCH 2.6.26-rc5 1/2] " Hinko Kočevar
2008-06-06 11:41   ` Alan Cox [this message]
2008-06-06 12:12     ` Hinko Koc(evar
2008-06-06 15:05       ` Alan Cox
2008-06-06 11:38 ` [PATCH 2.6.26-rc5 2/2] " Hinko Kočevar
2008-06-06 18:32 ` [PATCH 2.6.26-rc5 0/2] " Adrian Bunk
2008-06-10  9:49   ` Jesper Nilsson
2008-06-10 10:15     ` Stephen Rothwell
2008-07-01 14:08 ` [PATCH linux-next 1/1] cris: look for linker scripts in srctree not in objtree Hinko Kocevar
2008-07-01 16:02   ` Jesper Nilsson
2008-07-01 19:29     ` Sam Ravnborg
2008-07-02  7:13     ` Hinko Kocevar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080606124149.2d87f980@core \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=dev-etrax@axis.com \
    --cc=hinko.kocevar@cetrtapot.si \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox