From: Scott Wiersdorf <scott@bluehost.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Balbir Singh <balbir@in.ibm.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
matt@bluehost.com
Subject: Re: [PATCH 2.6.25-4] getdelays.c: signal handling for log rotation
Date: Fri, 6 Jun 2008 14:42:08 -0600 [thread overview]
Message-ID: <20080606204208.GB4283@perlcode.org> (raw)
In-Reply-To: <87d4muu0k2.fsf@basil.nowhere.org>
On Fri, Jun 06, 2008 at 03:59:09PM +0200, Andi Kleen wrote:
> Scott Wiersdorf <scott@perlcode.org> writes:
>
> > This adds a USR1 signal handler to getdelays.c, which causes getdelays
> > to close its logfile and reopen it (if '-w logfile' is
> > specified). This is useful in situations when getdelays is running for
> > a long time (i.e, the log file growing) and you need to rotate the
> > logs but don't want to lose any log data.
>
> You could do the same by sending SIGSTOP; copy file; truncate file; SIGCONT
I believe it, but you can miss a lot of important stuff between STOP
and CONT, especially on a busy system. With a single handler that
reopens the file, you'll miss at most one netlink datum packet, and
most of the time you'll miss nothing.
Scott
--
Scott Wiersdorf
<scott@bluehost.com>
next prev parent reply other threads:[~2008-06-06 21:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 19:43 [PATCH 2.6.25-4] getdelays.c: signal handling for log rotation Scott Wiersdorf
2008-06-06 3:46 ` Balbir Singh
2008-06-06 20:40 ` Scott Wiersdorf
2008-06-06 13:59 ` Andi Kleen
2008-06-06 20:42 ` Scott Wiersdorf [this message]
2008-06-07 1:10 ` Andi Kleen
2008-06-06 20:47 ` Scott Wiersdorf
2008-06-07 1:13 ` Andi Kleen
2008-06-09 14:20 ` Scott Wiersdorf
2008-06-09 14:42 ` Balbir Singh
2008-06-30 19:52 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080606204208.GB4283@perlcode.org \
--to=scott@bluehost.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=balbir@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@bluehost.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox