serial/bfin_5xx.c build error

serial/bfin_5xx.c build error

[Adrian Bunk]

Commit 7d01b475ab17018756c8df27c2ee3c220fab05f8
(Blackfin Serial Driver: Enable IR function when user application)
causes the following build error:

<--  snip  -->

...
  CC      drivers/serial/bfin_5xx.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c: In function 'bfin_serial_init':
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c:1209: error: 'struct tty_driver' has no member named 'set_ldisc'
make[3]: *** [drivers/serial/bfin_5xx.o] Error 1

<--  snip  -->

In case it can't be fixed quickly a revert might be an option for 2.6.26.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: serial/bfin_5xx.c build error

[Bryan Wu]

On Sat, Jun 7, 2008 at 12:22 AM, Adrian Bunk <bunk@kernel.org> wrote:
> Commit 7d01b475ab17018756c8df27c2ee3c220fab05f8
> (Blackfin Serial Driver: Enable IR function when user application)
> causes the following build error:
>
> <--  snip  -->
>
> ...
>  CC      drivers/serial/bfin_5xx.o
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c: In function 'bfin_serial_init':
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c:1209: error: 'struct tty_driver' has no member named 'set_ldisc'
> make[3]: *** [drivers/serial/bfin_5xx.o] Error 1
>
> <--  snip  -->
>
> In case it can't be fixed quickly a revert might be an option for 2.6.26.
>

Graf has already sent me a patch to fix this. After I test it on my
board, I will send it out for Linus git pull.

Thanks a lot
-Bryan

Re: serial/bfin_5xx.c build error

[Mike Frysinger]

On Fri, Jun 6, 2008 at 12:40 PM, Bryan Wu <cooloney@kernel.org> wrote:
> On Sat, Jun 7, 2008 at 12:22 AM, Adrian Bunk <bunk@kernel.org> wrote:
>> Commit 7d01b475ab17018756c8df27c2ee3c220fab05f8
>> (Blackfin Serial Driver: Enable IR function when user application)
>> causes the following build error:
>>
>> <--  snip  -->
>>
>> ...
>>  CC      drivers/serial/bfin_5xx.o
>> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c: In function 'bfin_serial_init':
>> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c:1209: error: 'struct tty_driver' has no member named 'set_ldisc'
>> make[3]: *** [drivers/serial/bfin_5xx.o] Error 1
>>
>> <--  snip  -->
>>
>> In case it can't be fixed quickly a revert might be an option for 2.6.26.
>>
>
> Graf has already sent me a patch to fix this. After I test it on my
> board, I will send it out for Linus git pull.

i dont think there's anything for us to do on our side.  i thought
Alan was sending the fix out for 2.6.26.
-mike

Re: serial/bfin_5xx.c build error

[Bryan Wu]

On Sat, Jun 7, 2008 at 3:53 AM, Mike Frysinger <vapier.adi@gmail.com> wrote:
> On Fri, Jun 6, 2008 at 12:40 PM, Bryan Wu <cooloney@kernel.org> wrote:
>> On Sat, Jun 7, 2008 at 12:22 AM, Adrian Bunk <bunk@kernel.org> wrote:
>>> Commit 7d01b475ab17018756c8df27c2ee3c220fab05f8
>>> (Blackfin Serial Driver: Enable IR function when user application)
>>> causes the following build error:
>>>
>>> <--  snip  -->
>>>
>>> ...
>>>  CC      drivers/serial/bfin_5xx.o
>>> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c: In function 'bfin_serial_init':
>>> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c:1209: error: 'struct tty_driver' has no member named 'set_ldisc'
>>> make[3]: *** [drivers/serial/bfin_5xx.o] Error 1
>>>
>>> <--  snip  -->
>>>
>>> In case it can't be fixed quickly a revert might be an option for 2.6.26.
>>>
>>
>> Graf has already sent me a patch to fix this. After I test it on my
>> board, I will send it out for Linus git pull.
>
> i dont think there's anything for us to do on our side.  i thought
> Alan was sending the fix out for 2.6.26.
> -mike
>

Oh, no. Even with Alan and Linus pathc, we still need to fix some API change.
I will send it out soon.

-Bryan

Re: serial/bfin_5xx.c build error

[Alan Cox]

> In case it can't be fixed quickly a revert might be an option for 2.6.26.

A revert wouldn't be an option as quick check would show you.

The needed enabler patch went into Linus tree so the other fix should
follow before 2.6.26 and all will be well.

Alan

serial/bfin_5xx.c build error

[Adrian Bunk]

Seems to be broken by Alan's changes:

<--  snip  -->

...
  CC      drivers/serial/bfin_5xx.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c: In function 'bfin_serial_set_ldisc':
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c:820: error: 'struct tty_ldisc' has no member named 'num'
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c: In function 'bfin_serial_console_write':
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c:1001: warning: comparison of distinct pointer types lacks a cast
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c:1003: warning: comparison of distinct pointer types lacks a cast
make[3]: *** [drivers/serial/bfin_5xx.o] Error 1

<--  snip  -->

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: serial/bfin_5xx.c build error

[Bryan Wu]

On Sun, Aug 3, 2008 at 2:16 AM, Adrian Bunk <bunk@kernel.org> wrote:
> Seems to be broken by Alan's changes:
>

I'm trying to locate the Alan's change, do you know it, Adrian?


> <--  snip  -->
>
> ...
>  CC      drivers/serial/bfin_5xx.o
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c: In function 'bfin_serial_set_ldisc':
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c:820: error: 'struct tty_ldisc' has no member named 'num'
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c: In function 'bfin_serial_console_write':
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c:1001: warning: comparison of distinct pointer types lacks a cast
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c:1003: warning: comparison of distinct pointer types lacks a cast
> make[3]: *** [drivers/serial/bfin_5xx.o] Error 1
>
> <--  snip  -->

So is this bug in mainline upstream or linux-next latest tree?

Thanks
-Bryan

Re: serial/bfin_5xx.c build error

[Adrian Bunk]

On Tue, Aug 05, 2008 at 11:58:44AM +0800, Bryan Wu wrote:
> On Sun, Aug 3, 2008 at 2:16 AM, Adrian Bunk <bunk@kernel.org> wrote:
> > Seems to be broken by Alan's changes:
> >
> 
> I'm trying to locate the Alan's change, do you know it, Adrian?
> 
> > <--  snip  -->
> >
> > ...
> >  CC      drivers/serial/bfin_5xx.o
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c: In function 'bfin_serial_set_ldisc':
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c:820: error: 'struct tty_ldisc' has no member named 'num'
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c: In function 'bfin_serial_console_write':
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c:1001: warning: comparison of distinct pointer types lacks a cast
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c:1003: warning: comparison of distinct pointer types lacks a cast
> > make[3]: *** [drivers/serial/bfin_5xx.o] Error 1
> >
> > <--  snip  -->
> 
> So is this bug in mainline upstream or linux-next latest tree?

It was a bug in the mainline upstream kernel.

Alan fixed it with comit b1cbefe5d5fc2d4a6109961d914027172ce8e152 
(blackfin: Fix compile failure in tty code) that went into
Linus' tree last night.

> Thanks
> -Bryan

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: serial/bfin_5xx.c build error

[Alan Cox]

> > <--  snip  -->
> 
> So is this bug in mainline upstream or linux-next latest tree?

2.6.27-rc - and I've sent Linus the fix

Alan