public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: kosaki.motohiro@jp.fujitsu.com
Cc: LKML <linux-kernel@vger.kernel.org>, linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH 4/5] add throttle to shrink_zone()
Date: Sun, 8 Jun 2008 13:12:03 -0700	[thread overview]
Message-ID: <20080608131203.e8cd69b7.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080605021505.306358710@jp.fujitsu.com>

On Thu, 05 Jun 2008 11:12:15 +0900 kosaki.motohiro@jp.fujitsu.com wrote:

> add throttle to shrink_zone() for performance improvement and prevent incorrect oom.

We should have a description of how all this works, please.  I thought
that was present in earlier iterations of this patchset.

It's quite hard and quite unreliable to reverse engineer both the
design and your thinking from the implementation.


  reply	other threads:[~2008-06-08 20:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-05  2:12 [PATCH 0/5] page reclaim throttle v7 kosaki.motohiro
2008-06-05  2:06 ` KAMEZAWA Hiroyuki
2008-06-05  2:23   ` KOSAKI Motohiro
2008-06-05  2:12 ` [PATCH 1/5] fix incorrect variable type of do_try_to_free_pages() kosaki.motohiro
2008-06-05  1:26   ` KOSAKI Motohiro
2008-06-05  2:12 ` [PATCH 2/5] introduce get_vm_event() kosaki.motohiro
2008-06-05  1:29   ` KOSAKI Motohiro
2008-06-05  2:12 ` [PATCH 3/5] change return type of shrink_zone() kosaki.motohiro
2008-06-05  2:12 ` [PATCH 4/5] add throttle to shrink_zone() kosaki.motohiro
2008-06-08 20:12   ` Andrew Morton [this message]
2008-06-09  0:38     ` KOSAKI Motohiro
2008-06-05  2:12 ` [PATCH 5/5] introduce sysctl of throttle kosaki.motohiro
2008-06-08 20:09   ` Andrew Morton
2008-06-09  0:37     ` KOSAKI Motohiro
2008-06-08 20:10   ` Andrew Morton
2008-06-09  0:34     ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080608131203.e8cd69b7.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox