* [patch] [PATCH] Use BOOTMEM_EXCLUSIVE for i386
@ 2008-06-08 14:16 Bernhard Walle
2008-06-18 9:49 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Bernhard Walle @ 2008-06-08 14:16 UTC (permalink / raw)
To: kexec; +Cc: linux-kernel, mingo, anderson, hpa, tglx, vgoyal
This patch uses the BOOTMEM_EXCLUSIVE for crashkernel reservation also for i386
and prints a error message on failure.
The patch is still for 2.6.26 since it is only bug fixing. The unification of
reserve_crashkernel() between i386 and x86_64 should be done for 2.6.27.
Signed-off-by: Bernhard Walle <bwalle@suse.de>
---
arch/x86/kernel/setup_32.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
--- a/arch/x86/kernel/setup_32.c
+++ b/arch/x86/kernel/setup_32.c
@@ -532,10 +532,16 @@ static void __init reserve_crashkernel(v
(unsigned long)(crash_size >> 20),
(unsigned long)(crash_base >> 20),
(unsigned long)(total_mem >> 20));
+
+ if (reserve_bootmem(crash_base, crash_size,
+ BOOTMEM_EXCLUSIVE) < 0) {
+ printk(KERN_INFO "crashkernel reservation "
+ "failed - memory is in use\n");
+ return;
+ }
+
crashk_res.start = crash_base;
crashk_res.end = crash_base + crash_size - 1;
- reserve_bootmem(crash_base, crash_size,
- BOOTMEM_DEFAULT);
} else
printk(KERN_INFO "crashkernel reservation failed - "
"you have to specify a base address\n");
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] [PATCH] Use BOOTMEM_EXCLUSIVE for i386
2008-06-08 14:16 [patch] [PATCH] Use BOOTMEM_EXCLUSIVE for i386 Bernhard Walle
@ 2008-06-18 9:49 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-06-18 9:49 UTC (permalink / raw)
To: kexec, linux-kernel, mingo, anderson, hpa, tglx, vgoyal
Cc: Yinghai Lu, the arch/x86 maintainers
* Bernhard Walle <bwalle@suse.de> wrote:
> This patch uses the BOOTMEM_EXCLUSIVE for crashkernel reservation also
> for i386 and prints a error message on failure.
>
> The patch is still for 2.6.26 since it is only bug fixing. The
> unification of reserve_crashkernel() between i386 and x86_64 should be
> done for 2.6.27.
applied to tip/x86/urgent, thanks Bernhard.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-06-18 9:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-08 14:16 [patch] [PATCH] Use BOOTMEM_EXCLUSIVE for i386 Bernhard Walle
2008-06-18 9:49 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox