* [PATCH] sched: Kill off dead cfs_rq_set_shares().
@ 2008-06-09 8:12 Paul Mundt
2008-06-10 12:51 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Paul Mundt @ 2008-06-09 8:12 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel
Building with CONFIG_FAIR_GROUP_SCHED=y on UP results in an unused
cfs_rq_set_shares() reference. As nothing is using this dummy function
in the first place, just kill it off.
Against current git, but still seems to be relevant to 'sched-devel' in
-tip.
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
---
kernel/sched.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index bfb8ad8..25de9ef 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -1471,16 +1471,8 @@ static unsigned long source_load(int cpu, int type);
static unsigned long target_load(int cpu, int type);
static unsigned long cpu_avg_load_per_task(int cpu);
static int task_hot(struct task_struct *p, u64 now, struct sched_domain *sd);
-#else /* CONFIG_SMP */
-
-#ifdef CONFIG_FAIR_GROUP_SCHED
-static void cfs_rq_set_shares(struct cfs_rq *cfs_rq, unsigned long shares)
-{
-}
#endif
-#endif /* CONFIG_SMP */
-
#include "sched_stats.h"
#include "sched_idletask.c"
#include "sched_fair.c"
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sched: Kill off dead cfs_rq_set_shares().
2008-06-09 8:12 [PATCH] sched: Kill off dead cfs_rq_set_shares() Paul Mundt
@ 2008-06-10 12:51 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-06-10 12:51 UTC (permalink / raw)
To: Paul Mundt, linux-kernel
* Paul Mundt <lethal@linux-sh.org> wrote:
> Building with CONFIG_FAIR_GROUP_SCHED=y on UP results in an unused
> cfs_rq_set_shares() reference. As nothing is using this dummy function
> in the first place, just kill it off.
>
> Against current git, but still seems to be relevant to 'sched-devel'
> in -tip.
applied, thanks Paul.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-06-10 12:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-09 8:12 [PATCH] sched: Kill off dead cfs_rq_set_shares() Paul Mundt
2008-06-10 12:51 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox