public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: update mptable v7 - fix
Date: Mon, 9 Jun 2008 12:13:18 +0200	[thread overview]
Message-ID: <20080609101318.GA23873@elte.hu> (raw)
In-Reply-To: <200806081953.26877.yhlu.kernel@gmail.com>


* Yinghai Lu <yhlu.kernel@gmail.com> wrote:

> [PATCH] x86: update mptable v7 - fix
> 
> need to call early_reserve_e820 to prelocate mptable for 32bit
> 
> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
> 
> Index: linux-2.6/arch/x86/kernel/setup_32.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/setup_32.c
> +++ linux-2.6/arch/x86/kernel/setup_32.c
> @@ -761,6 +761,8 @@ void __init setup_arch(char **cmdline_p)
>  	 */
>  	max_pfn = e820_end_of_ram();
>  
> +	/* pre allocte 4k for mptable mpc */
> +	early_reserve_e820_mpc_new();

applied, thanks. It needed the small build fix below as well, for UP 
32-bit.

	Ingo

--------------->
commit 3c803fb3e1972566f7a1613f53f7e5a70fbde83f
Author: Ingo Molnar <mingo@elte.hu>
Date:   Sun May 25 21:16:06 2008 +0200

    x86, mpparse: build fix
    
    fix:
    
      LD      .tmp_vmlinux1
      arch/x86/kernel/built-in.o: In function `setup_arch':
      : undefined reference to `early_reserve_e820_mpc_new'
    
    Signed-off-by: Ingo Molnar <mingo@elte.hu>

diff --git a/include/asm-x86/mpspec.h b/include/asm-x86/mpspec.h
index 6e9c958..b8ba374 100644
--- a/include/asm-x86/mpspec.h
+++ b/include/asm-x86/mpspec.h
@@ -46,7 +46,11 @@ extern unsigned long mp_lapic_addr;
 
 extern void find_smp_config(void);
 extern void get_smp_config(void);
+#ifdef CONFIG_X86_MPPARSE
 extern void early_reserve_e820_mpc_new(void);
+#else
+static inline void early_reserve_e820_mpc_new(void) { }
+#endif
 
 void __cpuinit generic_processor_info(int apicid, int version);
 #ifdef CONFIG_ACPI


  reply	other threads:[~2008-06-09 10:13 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200805041823.57198.yhlu.kernel@gmail.com>
2008-05-06 17:38 ` [PATCH] x86: update mptable Yinghai Lu
2008-05-06 17:41   ` [PATCH] x86: fixed mtrr change WP to WB Yinghai Lu
2008-05-06 17:48     ` H. Peter Anvin
2008-05-06 18:24       ` Yinghai Lu
2008-05-06 18:31         ` H. Peter Anvin
2008-05-06 18:34           ` Yinghai Lu
2008-05-06 18:43             ` H. Peter Anvin
2008-05-06 19:05               ` Yinghai Lu
2008-05-06 19:08                 ` H. Peter Anvin
2008-05-06 19:15                   ` Yinghai Lu
2008-05-07  7:48   ` [PATCH] x86: update mptable v2 Yinghai Lu
2008-05-17  2:32     ` [PATCH] x86: update mptable v3 Yinghai Lu
2008-05-19 15:46       ` Ingo Molnar
2008-05-19 19:35       ` [PATCH] x86: update mptable v4 Yinghai Lu
2008-05-19 19:52         ` [PATCH] x86: update mptable v5 Yinghai Lu
2008-05-25 23:00           ` [PATCH] x86: update mptable v6 Yinghai Lu
2008-06-01 20:17             ` [PATCH] x86: update mptable v7 Yinghai Lu
2008-06-09  2:53               ` [PATCH] x86: update mptable v7 - fix Yinghai Lu
2008-06-09 10:13                 ` Ingo Molnar [this message]
2008-06-09 17:51                   ` Yinghai Lu
2008-06-09 18:11                     ` Maciej W. Rozycki
2008-06-09 19:09                     ` Ingo Molnar
2008-06-09 19:38                       ` Yinghai Lu
2008-06-09 19:46                         ` H. Peter Anvin
2008-06-09 19:49                       ` Maciej W. Rozycki
2008-06-18 21:32               ` [PATCH] x86: update mptable fix with no ioapic Yinghai Lu
2008-06-19  0:29                 ` [PATCH] x86: update mptable fix with no ioapic v2 Yinghai Lu
2008-06-19  7:18                   ` [PATCH] x86: let MPS support selectable Yinghai Lu
2008-06-19 12:13                     ` Ingo Molnar
2008-06-19 12:49                       ` Ingo Molnar
2008-06-19 15:10                     ` Maciej W. Rozycki
2008-06-19 17:39                       ` Yinghai Lu
2008-06-19 18:03                         ` Len Brown
2008-06-19 18:48                           ` Maciej W. Rozycki
2008-06-26  9:31                             ` Ingo Molnar
     [not found]                     ` <200806191213.10312.yhlu.kernel@gmail.com>
2008-06-19 19:15                       ` [PATCH] x86: fix compiling when CONFIG_X86_MPPARSE is not set Yinghai Lu
2008-06-20 14:42                         ` [PATCH] x86: check command line " Yinghai Lu
2008-06-20 15:01                           ` Ingo Molnar
2008-06-20 15:04                             ` Yinghai Lu
2008-06-20 15:36                             ` Maciej W. Rozycki
2008-06-20 23:11                           ` [PATCH] x86: check command line when CONFIG_X86_MPPARSE is not set v2 Yinghai Lu
2008-06-21  8:14                             ` [PATCH] x86: clean up init_amd() Yinghai Lu
2008-06-24 12:12                           ` [PATCH] x86: check command line when CONFIG_X86_MPPARSE is not set Pavel Machek
2008-06-26  8:23                             ` Yinghai Lu
     [not found]                       ` <200806200733.31477.yhlu.kernel@gmail.com>
2008-06-20 15:03                         ` [PATCH] x86: simplify x86_mpparse dependency check Ingo Molnar
2008-06-20 15:31                         ` Maciej W. Rozycki
2008-06-19 12:13                   ` [PATCH] x86: update mptable fix with no ioapic v2 Ingo Molnar
2008-06-18 22:18               ` [PATCH] x86: update mptable v7 Len Brown
2008-06-18 22:32                 ` Yinghai Lu
2008-06-19  0:33                   ` Len Brown
2008-06-19  0:49                     ` Yinghai Lu
2008-06-19  4:32                       ` Eric W. Biederman
2008-06-19  5:09                         ` H. Peter Anvin
2008-06-19  5:11                         ` Yinghai Lu
2008-06-19  5:27                         ` Len Brown
2008-06-19  6:37                           ` Eric W. Biederman
2008-06-19  7:31                             ` Yinghai Lu
2008-06-19 18:16                               ` Len Brown
2008-06-20  6:47                                 ` Ingo Molnar
2008-06-20  7:20                                   ` Yinghai Lu
2008-06-20  9:12                                   ` Andi Kleen
2008-06-19  5:20                       ` Len Brown
2008-06-19  6:26                         ` Yinghai Lu
2008-06-19  6:28                           ` H. Peter Anvin
2008-06-19  6:35                             ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080609101318.GA23873@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox