From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1760717AbYFIKov@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760717AbYFIKov (ORCPT <rfc822;w@1wt.eu>);
	Mon, 9 Jun 2008 06:44:51 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754238AbYFIKon
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 9 Jun 2008 06:44:43 -0400
Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:57974 "EHLO
	lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1754070AbYFIKon (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 9 Jun 2008 06:44:43 -0400
Date: Mon, 9 Jun 2008 11:27:42 +0100
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
       Jiri Slaby <jirislaby@gmail.com>
Subject: Re: [PATCH] Char: mxser, ioctl cleanup
Message-ID: <20080609112742.420ff81b@core>
In-Reply-To: <1213006112-25965-1-git-send-email-jirislaby@gmail.com>
References: <1213006112-25965-1-git-send-email-jirislaby@gmail.com>
X-Mailer: Claws Mail 3.3.1 (GTK+ 2.12.5; x86_64-redhat-linux-gnu)
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>  	case MOXA_GET_MAJOR:
> +		printk(KERN_WARNING "mxser: '%s' uses deprecated ioctl %x, fix "
> +				"your userspace\n", current->comm, cmd);

Should be rate limited...

Rest looks good, break change is definitely what is needed.

Acked-by: Alan Cox <alan@redhat.com>