public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Andy Whitcroft <apw@shadowen.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-usb@vger.kernel.org
Subject: Re: update checkpatch.pl to version 0.19
Date: Mon, 9 Jun 2008 15:58:43 -0700	[thread overview]
Message-ID: <20080609225843.GA23391@kroah.com> (raw)
In-Reply-To: <1213009781.32207.615.camel@pmac.infradead.org>

On Mon, Jun 09, 2008 at 12:09:41PM +0100, David Woodhouse wrote:
> On Mon, 2008-06-09 at 09:33 +0100, Andy Whitcroft wrote:
> > The issue I have is I have a comprehensive test suite which is kept in
> > lock step with checkpatch itself, all in my own tree.  Now that is
> > just noise for mainline.  What I want to be able to do is keep that in
> > lock step with developments in my tree, but not merge it upstream.  So
> > far I've not found a workable solution with git for that.
> 
> Why not make a tree which automatically tracks Linus' tree but only
> includes checkpatch.pl. Then pull from that into your own tree before
> you push your changes back.

Or just use quilt.  Or git.  Or something that takes into account that
your file will change in the mainline tree.

Keeping code outside the kernel tree and then blindly doing a diff to
generate a patch for submission is never considered a good idea, and
causes real problems, as seen here.

thanks,

greg k-h

  reply	other threads:[~2008-06-09 23:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200806061922.m56JMJuq025990@hera.kernel.org>
2008-06-06 23:30 ` update checkpatch.pl to version 0.19 Greg KH
2008-06-07  6:02   ` Andrew Morton
2008-06-07 17:34     ` Greg KH
2008-06-09  8:33       ` Andy Whitcroft
2008-06-09 11:09         ` David Woodhouse
2008-06-09 22:58           ` Greg KH [this message]
2008-06-11  8:49             ` Andy Whitcroft
2008-06-09 15:56         ` Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080609225843.GA23391@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@shadowen.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox