From: Andrew Morton <akpm@linux-foundation.org>
To: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
Cc: jack@suse.cz, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org,
Satoshi OSHIMA <satoshi.oshima.fk@hitachi.com>,
sugita <yumiko.sugita.yf@hitachi.com>
Subject: Re: - jbd-strictly-check-for-write-errors-on-data-buffers.patch removed from -mm tree
Date: Tue, 10 Jun 2008 02:17:46 -0700 [thread overview]
Message-ID: <20080610021746.51e5cfa8.akpm@linux-foundation.org> (raw)
In-Reply-To: <484E4097.2010204@hitachi.com>
On Tue, 10 Jun 2008 17:51:35 +0900 Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com> wrote:
> Hello Andrew,
>
> akpm@linux-foundation.org wrote:
>
> > The patch titled
> > jbd: strictly check for write errors on data buffers
> > has been removed from the -mm tree. Its filename was
> > jbd-strictly-check-for-write-errors-on-data-buffers.patch
> >
> > This patch was dropped because I don't think we want to go read-only on file data write errors
> >
> > The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
> >
> > ------------------------------------------------------
> > Subject: jbd: strictly check for write errors on data buffers
> > From: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
>
> This patch series doesn't change the behavior on file data write
> errors as I stated before, but we found that the current behavior has
> been made accidentally. So yesterday I sent an additional patch(*)
> which removes the invocation of journal_abort() and thus stop making
> the fs read-only on file data write errors, but it seems to be late
> for the -mm release preparation.
>
> Patch(*) can be found at:
> http://marc.info/?l=linux-kernel&m=121300618614453&w=2
>
> Anyway, as this patch series was dropped from -mm, I'm going to
> send a revised version.
>
> I plan to separate these pathces into three patche set.
> The first patch (set) corrects the current behavior in ordered
> writes, it means it removes the invocation of journal_abort() on file
> data write errors. It is the almost same as the patch(*).
> The second patch set fixes error handlings for metadata writes and
> checkpointing. It should be applied independently of the first
> patch set, and it is the same as PATCH 3/5 to 5/5.
> The third patch set makes "abort the journal on file data write errors"
> tunable for mission critical users. Of course, this feature depends
> on the first patch set.
>
That sounds like a good plan, thanks.
next prev parent reply other threads:[~2008-06-10 9:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200806092212.m59MC553010889@imap1.linux-foundation.org>
2008-06-10 8:51 ` - jbd-strictly-check-for-write-errors-on-data-buffers.patch removed from -mm tree Hidehiro Kawai
2008-06-10 9:17 ` Andrew Morton [this message]
[not found] ` <170fa0d20807140708k46f86ac1tfee50d3fa14e3e41@mail.gmail.com>
2008-07-14 14:10 ` Mike Snitzer
2008-07-14 16:15 ` Andrew Morton
2008-07-15 2:06 ` Hidehiro Kawai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080610021746.51e5cfa8.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=satoshi.oshima.fk@hitachi.com \
--cc=yumiko.sugita.yf@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox