Re: [bug, 2.6.26-rc4/rc5] sporadic bootup crashes in blk_lookup_devt()/prepare_namespace()

[Greg KH <gregkh@suse.de>]

On Mon, Jun 09, 2008 at 08:58:18AM -0700, Linus Torvalds wrote:
> 
> 
> On Mon, 9 Jun 2008, Kay Sievers wrote:
> > 
> > I think we should keep the patch, as it fixed a different issue, and it
> > seems the bug was there even before the patch - the function was just
> > not called 3 times, so even more unlikely to trigger it.
> 
> No, before the patch we never did a "dev_to_disk()" on the device. We just 
> did
> 
> 	if (strcmp(dev->bus_id, name) == 0) {
> 		devt = dev->devt;
> 		break;
> 	}
> 
> and we simply didn't care if it was a disk or a partition - it would work 
> correctly for both.
> 
> Your patch made it simply not work for partitions at all (by dereferencing 
> an illegal address off them). My fix makes it ignore partitions entirely, 
> but I'm a bit nervous that there might be some setup that sets up *only* 
> partitions, not any base device at all. I guess that is unlikely, but it 
> worries me a bit.

Thanks for finding this, it looks correct to me.

greg k-h