Re: [patch 02/41] cpu alloc: The allocator

Christoph Lameter
2008-06-10T17:33:40Z

On Wed, 4 Jun 2008, Mike Travis wrote:

> I'm a bit confused. Why is DEFINE_PER_CPU_SHARED_ALIGNED() conditioned on
> ifdef MODULE?
>
> #ifdef MODULE
> #define SHARED_ALIGNED_SECTION ".data.percpu"
> #else
> #define SHARED_ALIGNED_SECTION ".data.percpu.shared_aligned"
> #endif
>
> #define DEFINE_PER_CPU_SHARED_ALIGNED(type, name) \
> __attribute__((__section__(SHARED_ALIGNED_SECTION))) \
> PER_CPU_ATTRIBUTES __typeof__(type) per_cpu__##name \
> ____cacheline_aligned_in_smp

Looks wrong to me. There can be shared objects even without modules.