public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: eranian@googlemail.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch 12/21] perfmon2 minimal:  sysfs interface
Date: Wed, 11 Jun 2008 07:49:55 -0700	[thread overview]
Message-ID: <20080611144955.GA20145@kroah.com> (raw)
In-Reply-To: <484daff1.1358560a.0808.0267@mx.google.com>

On Mon, Jun 09, 2008 at 03:34:25PM -0700, eranian@googlemail.com wrote:
> +
> +static struct kobject pfm_kernel_kobj;

Eeek, no, please look at Documentation/kobject.txt that says to not ever
have static kobjects.

I think a lot of this code can be cleaned up and shrunk given the way
that kobjects have changed recently.  See the examples in
samples/kobject/ and the documentation file for more details.

If you have any questions about it, please let me know.

Also, whenever you add a sysfs file to the kernel, please document it in
Documentation/ABI/ so that everyone knows what it is and how to use it.

thanks,

greg k-h

  reply	other threads:[~2008-06-11 14:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-09 22:34 [patch 12/21] perfmon2 minimal: sysfs interface eranian
2008-06-11 14:49 ` Greg KH [this message]
2008-06-11 15:00   ` stephane eranian
2008-06-12 12:54     ` stephane eranian
2008-06-13  3:50       ` Greg KH
2008-06-13  3:53       ` Greg KH
2008-06-13 22:31         ` stephane eranian
2008-06-17  8:52           ` stephane eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080611144955.GA20145@kroah.com \
    --to=greg@kroah.com \
    --cc=eranian@googlemail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox