From: Dave Jones <davej@redhat.com>
To: Ben Castricum <lk0806@bencastricum.nl>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [patch] x86: microcode: Cosmetic changes
Date: Wed, 11 Jun 2008 13:09:39 -0400 [thread overview]
Message-ID: <20080611170939.GA15146@redhat.com> (raw)
In-Reply-To: <alpine.LNX.1.10.0806101312170.14868@gateway.bencastricum.nl>
On Tue, Jun 10, 2008 at 01:15:12PM +0200, Ben Castricum wrote:
> @@ -805,6 +806,9 @@ static int __init microcode_init (void)
> {
> int error;
>
> + printk(KERN_INFO
> + "IA-32 Microcode Update Driver: v" MICROCODE_VERSION " <tigran@aivazian.fsnet.co.uk>\n");
> +
> error = microcode_dev_init();
> if (error)
> return error;
> @@ -825,9 +829,6 @@ static int __init microcode_init (void)
> }
>
> register_hotcpu_notifier(&mc_cpu_notifier);
> -
> - printk(KERN_INFO
> - "IA-32 Microcode Update Driver: v" MICROCODE_VERSION " <tigran@aivazian.fsnet.co.uk>\n");
> return 0;
By doing this before the registration of the sysdev, we'll
now be printing this on machines that don't have the microcode
update facility. Pointless spew, for no obvious gain imo.
[Why we go through so many hoops before we check if the CPU is
capable is a mystery to me. It would make more sense to have
that be the first thing that gets checked when this inits]
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2008-06-11 17:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-10 11:15 [patch] x86: microcode: Cosmetic changes Ben Castricum
2008-06-11 17:09 ` Dave Jones [this message]
2008-06-12 5:52 ` Giacomo Catenazzi
2008-06-12 7:48 ` Tigran Aivazian
2008-07-03 9:41 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080611170939.GA15146@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lk0806@bencastricum.nl \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox