From: Ralf Baechle <ralf@linux-mips.org>
To: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] [MIPS] The tickcount per-cpu variable can become static
Date: Wed, 11 Jun 2008 18:44:15 +0100 [thread overview]
Message-ID: <20080611174415.GE30400@linux-mips.org> (raw)
In-Reply-To: <12120730321843-git-send-email-dmitri.vorobiev@movial.fi>
On Thu, May 29, 2008 at 05:57:12PM +0300, Dmitri Vorobiev wrote:
> In arch/mips/mips-boards/generic/time.c, the `tickcount' per-cpu
> variable is needlessly defined global, and this patch makes it
> static.
>
> Noticed by sparse. Tested by booting a Qemu-emulated Malta board
> up to the shell prompt.
Patch is ok - except it tries to fix a piece of code which I've already
removed so I'll drop this one.
Ralf
prev parent reply other threads:[~2008-06-11 17:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 14:57 [PATCH 0/5] [MIPS] sparse noise reduction and namespace cleanups Dmitri Vorobiev
2008-05-29 14:57 ` [PATCH 1/5] [MIPS] fix sparse warning about setup_early_printk() Dmitri Vorobiev
2008-05-29 14:57 ` [PATCH 2/5] [MIPS] Make two functions static Dmitri Vorobiev
2008-05-29 14:57 ` [PATCH 3/5] [MIPS] remove unused function alloc_legacy_irqno() Dmitri Vorobiev
2008-05-29 14:57 ` [PATCH 4/5] [MIPS] unexport {allocate,free}_irqno Dmitri Vorobiev
2008-05-29 14:57 ` [PATCH 5/5] [MIPS] The tickcount per-cpu variable can become static Dmitri Vorobiev
2008-05-30 7:58 ` Dmitri Vorobiev
2008-06-11 17:44 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080611174415.GE30400@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=dmitri.vorobiev@movial.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox