From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Jiri Bohac <jbohac@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] console keyboard mapping broken by 04c71976
Date: Thu, 12 Jun 2008 02:18:32 +0100 [thread overview]
Message-ID: <20080612011832.GM4718@implementation> (raw)
In-Reply-To: <20080611134837.GA11462@midget.suse.cz>
Ok, a closer look agrees with the patch, but no need to keep the uni
variable then, here is an updated patch. Thanks!
From: Jiri Bohac <jbohac@suse.cz>
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
diff --git a/drivers/char/keyboard.c b/drivers/char/keyboard.c
index 7f7e798..16492b7 100644
--- a/drivers/char/keyboard.c
+++ b/drivers/char/keyboard.c
@@ -678,10 +678,5 @@
static void k_self(struct vc_data *vc, unsigned char value, char up_flag)
{
- unsigned int uni;
- if (kbd->kbdmode == VC_UNICODE)
- uni = value;
- else
- uni = conv_8bit_to_uni(value);
- k_unicode(vc, uni, up_flag);
+ k_unicode(vc, conv_8bit_to_uni(value), up_flag);
}
next prev parent reply other threads:[~2008-06-12 1:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-11 13:48 [PATCH] console keyboard mapping broken by 04c71976 Jiri Bohac
2008-06-11 14:03 ` Samuel Thibault
2008-06-11 15:10 ` Jiri Bohac
2008-06-11 15:23 ` Samuel Thibault
2008-06-12 1:18 ` Samuel Thibault [this message]
2008-06-12 1:27 ` Andrew Morton
2008-06-12 1:36 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080612011832.GM4718@implementation \
--to=samuel.thibault@ens-lyon.org \
--cc=akpm@linux-foundation.org \
--cc=jbohac@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox