The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Glauber Costa <gcosta@redhat.com>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: improved smpboot integration
Date: Fri, 13 Jun 2008 20:34:33 +0200	[thread overview]
Message-ID: <20080613183433.GA16119@elte.hu> (raw)
In-Reply-To: <200806131507.m5DF73Q7005595@pobox-2.corp.redhat.com>


* Glauber Costa <gcosta@redhat.com> wrote:

> Ingo, please pull the latest master git tree from:
> 
>    git://git.kernel.org/pub/scm/linux/kernel/git/glommer/linux-2.6-integration.git master
> 
> into your tip/master tree

thanks. I'm still testing it - found one problem so far, see the fix 
below.

btw., it makes sense to test-pull your own URIs to check it's all 
correct - the correct URI above is:

   git://git.kernel.org/pub/scm/linux/kernel/git/glommer/linux-2.6-x86-integration.git master

	Ingo

--------------->
commit 25acfcc76e4ca3120d5ac36be17ff2c3319421b0
Author: Ingo Molnar <mingo@elte.hu>
Date:   Fri Jun 13 20:31:54 2008 +0200

    x86: fix sleep.c build error
    
    fix:
    
    arch/x86/kernel/acpi/sleep.c: In function ‘acpi_save_state_mem':
    arch/x86/kernel/acpi/sleep.c:75: error: ‘stack_start' undeclared (first use in this function)
    arch/x86/kernel/acpi/sleep.c:75: error: (Each undeclared identifier is reported
    only once
    arch/x86/kernel/acpi/sleep.c:75: error: for each function it appears in.)

diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c
index 0103af2..cd1edab 100644
--- a/arch/x86/kernel/acpi/sleep.c
+++ b/arch/x86/kernel/acpi/sleep.c
@@ -72,7 +72,9 @@ int acpi_save_state_mem(void)
 	saved_magic = 0x12345678;
 #else /* CONFIG_64BIT */
 	header->trampoline_segment = setup_trampoline() >> 4;
+#ifdef CONFIG_SMP
 	stack_start.sp = temp_stack + 4096;
+#endif
 	initial_code = (unsigned long)wakeup_long64;
 	saved_magic = 0x123456789abcdef0;
 #endif /* CONFIG_64BIT */

      reply	other threads:[~2008-06-13 18:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-13 15:07 improved smpboot integration Glauber Costa
2008-06-13 18:34 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080613183433.GA16119@elte.hu \
    --to=mingo@elte.hu \
    --cc=gcosta@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox