From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760350AbYFOSXk (ORCPT ); Sun, 15 Jun 2008 14:23:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759222AbYFOSXP (ORCPT ); Sun, 15 Jun 2008 14:23:15 -0400 Received: from yw-out-2324.google.com ([74.125.46.30]:62276 "EHLO yw-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758974AbYFOSXL (ORCPT ); Sun, 15 Jun 2008 14:23:11 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:mime-version:content-type :content-transfer-encoding:content-disposition:message-id; b=gJEeQLdxCZhKXDM+rYJUtCz4GWN9uxZcGNiPkTLhpcSSRA/B8/Yv68W3qBGrD2lvdO aOIUOC8xiqitv9PwsfkEI4gxhqJeKS0vhQ2nVMcc1YkIqtM3gGqBWSDpGhQTc2uJFEvO W16OGyoF0PAr6AH+FN4wKuvx8AMJdAbn6MRLU= From: Bartlomiej Zolnierkiewicz To: linux-ide@vger.kernel.org Subject: [PATCH] ide: increase timeout in wait_drive_not_busy() Date: Sun, 15 Jun 2008 20:24:24 +0200 User-Agent: KMail/1.9.9 Cc: linux-kernel@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200806152024.24596.bzolnier@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some ATAPI devices take longer than the current max timeout value to become ready (i.e. TEAC DV-W28ECW takes 6 ms) so increase the timeout value to 10 ms. This fixes kernel.org bugzilla bug #10887: http://bugzilla.kernel.org/show_bug.cgi?id=10887 Reported-by: Masanari Iida Signed-off-by: Bartlomiej Zolnierkiewicz --- draft patch, I'm waiting on feedback from Masanari on this one drivers/ide/ide-taskfile.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: b/drivers/ide/ide-taskfile.c =================================================================== --- a/drivers/ide/ide-taskfile.c +++ b/drivers/ide/ide-taskfile.c @@ -225,10 +225,10 @@ static u8 wait_drive_not_busy(ide_drive_ u8 stat; /* - * Last sector was transfered, wait until drive is ready. - * This can take up to 10 usec, but we will wait max 1 ms. + * Last sector was transfered, wait until device is ready. This can + * take up to 6 ms on some ATAPI devices, so we will wait max 10 ms. */ - for (retries = 0; retries < 100; retries++) { + for (retries = 0; retries < 1000; retries++) { stat = ide_read_status(drive); if (stat & BUSY_STAT)