From: Ben Dooks <ben-linux@fluff.org>
To: linux-kernel@vger.kernel.org
Cc: drzeus-mmc@drzeus.cx, Ben Dooks <ben-linux@fluff.org>
Subject: [patch v2 16/16] MMC: S3C24XX: Add media presence test to request handling.
Date: Mon, 16 Jun 2008 15:35:01 +0100 [thread overview]
Message-ID: <20080616143515.192750633@fluff.org.uk> (raw)
In-Reply-To: 20080616143445.451023326@fluff.org.uk
[-- Attachment #1: simtec/s3c24xx-sdmmc-add-mediacheck.patch --]
[-- Type: text/plain, Size: 2123 bytes --]
Ensure that we have physical media present before attempting to
send a request to a card. This ensures that we do not get flooded
by errors from commands that can never be completed timing out.
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Index: linux-2.6.26-rc5-q2/drivers/mmc/host/s3cmci.c
===================================================================
--- linux-2.6.26-rc5-q2.orig/drivers/mmc/host/s3cmci.c 2008-06-16 15:25:12.000000000 +0100
+++ linux-2.6.26-rc5-q2/drivers/mmc/host/s3cmci.c 2008-06-16 15:25:13.000000000 +0100
@@ -985,6 +985,20 @@ static void s3cmci_send_request(struct m
enable_irq(host->irq);
}
+static int s3cmci_card_present(struct s3cmci_host *host)
+{
+ struct s3c24xx_mci_pdata *pdata = host->pdata;
+ int ret;
+
+ /* if we can't detect the presence, then always have card. */
+ if (pdata->gpio_detect == 0)
+ return 1;
+
+ ret = s3c2410_gpio_getpin(pdata->gpio_detect) ? 0 : 1;
+
+ return ret ^ pdata->detect_invert;
+}
+
static void s3cmci_request(struct mmc_host *mmc, struct mmc_request *mrq)
{
struct s3cmci_host *host = mmc_priv(mmc);
@@ -992,7 +1006,12 @@ static void s3cmci_request(struct mmc_ho
host->cmd_is_stop = 0;
host->mrq = mrq;
- s3cmci_send_request(mmc);
+ if (!s3cmci_card_present(host)) {
+ dbg(host, dbg_err, "%s: no medium present\n", __func__);
+ host->mrq->cmd->error = -ENOMEDIUM;
+ mmc_request_done(mmc, mrq);
+ } else
+ s3cmci_send_request(mmc);
}
static void s3cmci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
Index: linux-2.6.26-rc5-q2/include/asm-arm/arch-s3c2410/mci.h
===================================================================
--- linux-2.6.26-rc5-q2.orig/include/asm-arm/arch-s3c2410/mci.h 2008-06-16 15:25:01.000000000 +0100
+++ linux-2.6.26-rc5-q2/include/asm-arm/arch-s3c2410/mci.h 2008-06-16 15:25:13.000000000 +0100
@@ -3,6 +3,7 @@
struct s3c24xx_mci_pdata {
unsigned int wprotect_invert : 1;
+ unsigned int detect_invert : 1; /* set => detect active high. */
unsigned int gpio_detect;
unsigned int gpio_wprotect;
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
next prev parent reply other threads:[~2008-06-16 14:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 14:34 [patch v2 00/16] S3C24XX SD/MMC driver Ben Dooks
2008-06-16 14:34 ` [patch v2 01/16] MMC: S3C24XX MMC/SD driver Ben Dooks
2008-06-16 14:34 ` [patch v2 02/16] MMC: S3C24XX: Fix the checkpatch.pl errors in the s3cmci driver Ben Dooks
2008-06-16 15:07 ` Ben Dooks
2008-06-16 14:34 ` [patch v2 03/16] MMC: S3C24XX MMC/SD driver write fixes Ben Dooks
2008-06-16 14:34 ` [patch v2 04/16] MMC: DMA free fix for S3C24XX SD/MMC driver Ben Dooks
2008-06-16 14:34 ` [patch v2 05/16] MMC: S3C24XX MMC/SD stop fix Ben Dooks
2008-06-16 14:34 ` [patch v2 06/16] MMC: Fix S3C24XX IRQ enable during PIO transfers Ben Dooks
2008-06-16 14:34 ` [patch v2 07/16] MMC: S3C24XX: Add platform data for MMC/SD driver Ben Dooks
2008-06-16 14:34 ` [patch v2 08/16] MMC: S3C24XX: Add support to invert write protect line Ben Dooks
2008-06-16 14:34 ` [patch v2 09/16] MMC: S3C24XX: Ensure host->mrq->data is valid Ben Dooks
2008-06-16 14:34 ` [patch v2 10/16] MMC: S3C24XX: Allow card-detect on non-IRQ capable pin Ben Dooks
2008-06-16 14:34 ` [patch v2 11/16] MMC: S3C24XX: Fix s3c2410_dma_request() return code check Ben Dooks
2008-06-16 14:34 ` [patch v2 12/16] MMC: S3C24XX: Fix MMC return codes Ben Dooks
2008-06-16 14:34 ` [patch v2 13/16] MMC: S3C24XX: MMC/SD driver fix use of sg lists Ben Dooks
2008-06-16 14:34 ` [patch v2 14/16] MMC: S3C24XX: Add MODULE_ALIAS() entries for the platform devices Ben Dooks
2008-06-16 14:35 ` [patch v2 15/16] MMC: S3C24XX: Fix use of msecs where jiffies are needed Ben Dooks
2008-06-16 14:35 ` Ben Dooks [this message]
2008-06-18 10:32 ` [patch v2 00/16] S3C24XX SD/MMC driver Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080616143515.192750633@fluff.org.uk \
--to=ben-linux@fluff.org \
--cc=drzeus-mmc@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox