From: Jack Steiner <steiner@sgi.com>
To: mingo@elte.hu, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] - Increase MAX_APICS for very large x86_64 configs
Date: Mon, 16 Jun 2008 12:09:10 -0500 [thread overview]
Message-ID: <20080616170910.GA24930@sgi.com> (raw)
Increase the maximum number of apics when running very large
configurations. This patch has no affect on most systems.
Signed-off-by: Jack Steiner <steiner@sgi.com>
---
The patch has no effect on any 32-bit kernel. It adds ~4k to the size
of 64-bit kernels but only if NR_CPUS > 255.
This is a repost of an earlier patch (4/16) that was implicated in
a random-qa failure. I have not been able to reproduce the failure
using the same boot args & config. Best guess is that some other
patch caused random data corruption & this patch was a victim.
include/asm-x86/mpspec_def.h | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
Index: linux/include/asm-x86/mpspec_def.h
===================================================================
--- linux.orig/include/asm-x86/mpspec_def.h 2008-06-08 09:05:51.140046529 -0500
+++ linux/include/asm-x86/mpspec_def.h 2008-06-08 09:05:55.244550306 -0500
@@ -17,10 +17,11 @@
# define MAX_MPC_ENTRY 1024
# define MAX_APICS 256
#else
-/*
- * A maximum of 255 APICs with the current APIC ID architecture.
- */
-# define MAX_APICS 255
+# if NR_CPUS <= 255
+# define MAX_APICS 255
+# else
+# define MAX_APICS 32768
+# endif
#endif
struct intel_mp_floating {
next reply other threads:[~2008-06-16 17:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 17:09 Jack Steiner [this message]
2008-06-19 10:10 ` [PATCH] - Increase MAX_APICS for very large x86_64 configs Ingo Molnar
2008-06-19 10:32 ` Ingo Molnar
2008-06-19 15:02 ` Jack Steiner
2008-06-19 15:17 ` Ingo Molnar
2008-06-19 15:19 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080616170910.GA24930@sgi.com \
--to=steiner@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox