public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: the arch/x86 maintainers <x86@kernel.org>,
	Stable Kernel <stable@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [stable] [PATCH 2/2] xen: don't drop NX bit
Date: Mon, 16 Jun 2008 15:35:08 -0700	[thread overview]
Message-ID: <20080616223508.GA1165@kroah.com> (raw)
In-Reply-To: <4856E2D4.3020402@goop.org>

On Mon, Jun 16, 2008 at 03:01:56PM -0700, Jeremy Fitzhardinge wrote:
> When converting the pfn/mfn in a pagetable entry, make sure we mask
> out the protection flags properly.  Formerly, this code was losing the
> NX bit, and not dealing with extra Xen-defined software flags in ptes.
> 
> Because NX is now enforced properly, we must put the hypercall page
> into the .text segment so that it is executable.
> 
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
> Cc: Stable Kernel <stable@kernel.org>

While it's great that you tell the stable people about this, but is it
realistic?  Is anyone using Xen as contained in the mainline kernel
these days?

If a distro were to be based on 2.6.25 and we take this patch, they will
just revert it back out due to their very large Xen patchset they apply
on top to get a "working" Xen version, right?

thanks,

greg k-h

  reply	other threads:[~2008-06-16 22:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-16 22:01 [PATCH 2/2] xen: don't drop NX bit Jeremy Fitzhardinge
2008-06-16 22:35 ` Greg KH [this message]
2008-06-16 22:51   ` [stable] " Jeremy Fitzhardinge
2008-06-16 23:37     ` Greg KH
2008-06-17 23:14       ` Chris Wright
2008-06-17 23:13   ` Chris Wright
2008-06-20 12:59 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080616223508.GA1165@kroah.com \
    --to=greg@kroah.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox