From: Rik van Riel <riel@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Hugh Dickins <hugh@veritas.com>,
Jens Axboe <jens.axboe@oracle.com>,
Lee Schermerhorn <lee.schermerhorn@hp.com>,
Pavel Machek <pavel@suse.cz>,
mtk.manpages@gmail.com,
kernel list <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: sync_file_range(SYNC_FILE_RANGE_WRITE) blocks?
Date: Tue, 17 Jun 2008 09:38:25 -0400 [thread overview]
Message-ID: <20080617093825.7a245f7f@bree.surriel.com> (raw)
In-Reply-To: <20080616215406.8f09e519.akpm@linux-foundation.org>
On Mon, 16 Jun 2008 21:54:06 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:
> > The problem with lots of CFQ requests is simpler.
> >
> > If you look at balance_dirty_pages() you will see that it only
> > takes dirty and NFS unstable pages into account when checking
> > the dirty limit. The pages that are in flight (under IO) are
> > not counted at all.
>
> That would be totally busted. All that nr_writeback logic in there is very
> much supposed to handle under-writeback pages?
Mmm, you are right. It is counting the number of writeback
pages.
It just isn't waiting on them. After moving enough pages from
dirty state to writeback state, it breaks out of the loop and
allows memory dirtying to continue.
if (pages_written >= write_chunk)
break; /* We've done our duty */
I wonder if we should wait for some IO to complete, or at least
do a simple congestion_wait() if the number of writeback pages
is very large?
--
All rights reversed.
next prev parent reply other threads:[~2008-06-17 13:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 10:26 sync_file_range(SYNC_FILE_RANGE_WRITE) blocks? Pavel Machek
2008-05-30 13:58 ` Hugh Dickins
2008-05-30 20:43 ` Pavel Machek
2008-05-31 18:44 ` Hugh Dickins
2008-06-01 0:39 ` Andrew Morton
2008-06-01 7:23 ` Hugh Dickins
2008-06-01 8:15 ` Andrew Morton
2008-06-01 11:40 ` Pavel Machek
2008-06-01 20:37 ` Andrew Morton
2008-06-01 22:00 ` Rafael J. Wysocki
2008-06-01 22:22 ` Pavel Machek
2008-06-01 22:47 ` Andrew Morton
2008-06-01 23:00 ` Pavel Machek
2008-06-01 23:11 ` Andrew Morton
2008-06-02 8:43 ` Hugh Dickins
2008-06-02 11:18 ` Rafael J. Wysocki
2008-06-02 12:11 ` Hugh Dickins
2008-06-02 11:43 ` Jens Axboe
2008-06-02 12:40 ` Hugh Dickins
2008-06-16 20:53 ` Rik van Riel
2008-06-17 4:54 ` Andrew Morton
2008-06-17 13:38 ` Rik van Riel [this message]
2008-06-02 16:50 ` Andrew Morton
2008-06-03 8:01 ` Michael Kerrisk
2008-06-03 8:05 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080617093825.7a245f7f@bree.surriel.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=jens.axboe@oracle.com \
--cc=lee.schermerhorn@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=pavel@suse.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox