The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Gaudenz Steinlin <gaudenz@debian.org>
To: linux-kernel@vger.kernel.org
Cc: 486798@bugs.debian.org, josejx@gentoo.org
Subject: [PATCH] restore export of handle_mm_fault for Mac on Linux
Date: Wed, 18 Jun 2008 12:14:02 +0200	[thread overview]
Message-ID: <20080618101402.GF15718@soziologie.ch> (raw)

[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]

Hi

The kernel modules for Mac on Linux (MOL) need handle_mm_fault. 
MOL is a GPL licensed virtual machine to run MacOS(X) on PPC Linux.

The export for handle_mm_fault was removed with commit
41f9dc5c871600f53c8912b2975971d2a11c1c25. 

Previously the export has been present since handle_mm_fault was
converted from an inline function to a non-inline one. See the thread
starting at http://marc.info/?l=linux-kernel&m=112327941709177&w=2 for
the initial discussion.

With commit 67207b9664a8d603138ef1556141e6d0a102bea7 the export was
moved from arch/ppc/kernel/ppc_ksyms.c to mm/memory.c. In this patch the
explanatory comment /* For MOL */ got lost. Thus to export was not moved
back to it's original place when it was no longer needed for spufs.

The attached patch restores the symbol export (GPL only) in it's
original place. Please consider applying it because this fixes a
regression for MOL.

Thanks

Gaudenz

P.S.: Please CC me and the corresponding Debian bug report on any
replies.

-- 
Ever tried. Ever failed. No matter.
Try again. Fail again. Fail better.
~ Samuel Beckett ~

[-- Attachment #2: mol-mm.patch --]
[-- Type: text/x-diff, Size: 494 bytes --]

diff --git a/arch/powerpc/kernel/ppc_ksyms.c b/arch/powerpc/kernel/ppc_ksyms.c
index c6b1aa3..455fb38 100644
--- a/arch/powerpc/kernel/ppc_ksyms.c
+++ b/arch/powerpc/kernel/ppc_ksyms.c
@@ -189,6 +189,7 @@ EXPORT_SYMBOL(set_context);
 extern long mol_trampoline;
 EXPORT_SYMBOL(mol_trampoline); /* For MOL */
 EXPORT_SYMBOL(flush_hash_pages); /* For MOL */
+EXPORT_SYMBOL(handle_mm_fault); /* For MOL */
 #ifdef CONFIG_SMP
 extern int mmu_hash_lock;
 EXPORT_SYMBOL(mmu_hash_lock); /* For MOL */

             reply	other threads:[~2008-06-18 10:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-18 10:14 Gaudenz Steinlin [this message]
2008-06-18 11:49 ` [PATCH] restore export of handle_mm_fault for Mac on Linux Christoph Hellwig
2008-06-18 12:45   ` Paul Mackerras
2008-06-18 12:51     ` Christoph Hellwig
2008-06-19  9:59       ` Gaudenz Steinlin
2008-06-18 17:18 ` Alan Cox
2008-06-19  9:58   ` Gaudenz Steinlin
2008-06-19 10:38     ` Christoph Hellwig
2008-06-19 10:46       ` Pekka Enberg
2008-06-19 11:01         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080618101402.GF15718@soziologie.ch \
    --to=gaudenz@debian.org \
    --cc=486798@bugs.debian.org \
    --cc=josejx@gentoo.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox