From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757438AbYFTN5Y (ORCPT ); Fri, 20 Jun 2008 09:57:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755843AbYFTN46 (ORCPT ); Fri, 20 Jun 2008 09:56:58 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:51772 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755661AbYFTN45 (ORCPT ); Fri, 20 Jun 2008 09:56:57 -0400 Date: Fri, 20 Jun 2008 15:56:45 +0200 From: Ingo Molnar To: Bernhard Walle Cc: linux-kernel@vger.kernel.org, yhlu.kernel@gmail.com Subject: Re: [PATCH] Unify crashkernel reservation for 32 and 64 bit Message-ID: <20080620135645.GD8135@elte.hu> References: <1213969102-17400-1-git-send-email-bwalle@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1213969102-17400-1-git-send-email-bwalle@suse.de> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Bernhard Walle wrote: > This patch moves the reserve_crashkernel() to setup.c and removes the > architecture-specific version. Both versions were more or less the > same. famous last words :) can you see any functionality difference between them? If yes, that should be declared. Ingo