From: Ingo Molnar <mingo@elte.hu>
To: Bernhard Walle <bwalle@suse.de>
Cc: linux-kernel@vger.kernel.org, yhlu.kernel@gmail.com,
the arch/x86 maintainers <x86@kernel.org>
Subject: Re: [PATCH] Unify crashkernel reservation for 32 and 64 bit
Date: Fri, 20 Jun 2008 15:58:47 +0200 [thread overview]
Message-ID: <20080620135847.GE8135@elte.hu> (raw)
In-Reply-To: <1213969102-17400-1-git-send-email-bwalle@suse.de>
* Bernhard Walle <bwalle@suse.de> wrote:
> This patch moves the reserve_crashkernel() to setup.c and removes the
> architecture-specific version. Both versions were more or less the
> same.
> ---
> arch/x86/kernel/setup.c | 61 ++++++++++++++++++++++++++++++++++++++++++++
> arch/x86/kernel/setup_32.c | 53 --------------------------------------
> arch/x86/kernel/setup_64.c | 40 ----------------------------
> include/asm-x86/setup.h | 3 ++
> 4 files changed, 64 insertions(+), 93 deletions(-)
also, tip/x86 has a ton of pending changes here already so your patch
does not apply:
patching file arch/x86/kernel/setup.c
Hunk #3 FAILED at 406.
1 out of 3 hunks FAILED -- rejects in file arch/x86/kernel/setup.c
patching file arch/x86/kernel/setup_32.c
Hunk #1 FAILED at 429.
1 out of 1 hunk FAILED -- rejects in file arch/x86/kernel/setup_32.c
patching file arch/x86/kernel/setup_64.c
Hunk #1 FAILED at 244.
1 out of 1 hunk FAILED -- rejects in file arch/x86/kernel/setup_64.c
patching file include/asm-x86/setup.h
Hunk #1 FAILED at 8.
1 out of 1 hunk FAILED -- rejects in file include/asm-x86/setup.h
you can pick up tip/master via:
http://people.redhat.com/mingo/tip.git/README
Ingo
next prev parent reply other threads:[~2008-06-20 13:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 13:38 [PATCH] Unify crashkernel reservation for 32 and 64 bit Bernhard Walle
2008-06-20 13:56 ` Ingo Molnar
2008-06-20 14:02 ` Bernhard Walle
2008-06-20 14:37 ` Ingo Molnar
2008-06-20 13:58 ` Ingo Molnar [this message]
2008-06-20 14:06 ` Bernhard Walle
2008-06-20 14:23 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080620135847.GE8135@elte.hu \
--to=mingo@elte.hu \
--cc=bwalle@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox