From: Ingo Molnar <mingo@elte.hu>
To: Michael Buesch <mb@bu3sch.de>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
David Ellingsworth <david@identd.dyndns.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH/RFC] remove irqs_disabled warning from local_bh_enable
Date: Fri, 20 Jun 2008 17:55:41 +0200 [thread overview]
Message-ID: <20080620155541.GC6656@elte.hu> (raw)
In-Reply-To: <200806201736.23916.mb@bu3sch.de>
* Michael Buesch <mb@bu3sch.de> wrote:
> On Friday 20 June 2008 17:27:48 Ingo Molnar wrote:
> > [<c012b361>] local_bh_enable_ip+0xd1/0xe0
> > [<c08d9f9f>] _spin_unlock_bh+0x2f/0x40
> > [<c0471b92>] vortex_timer+0xe2/0x3e0
>
> > real bug or false positive?
>
> Well, a timer runs with IRQs disabled, no? So this would be a bug.
indeed - agreed :) [no time for me to fix it, but can test any rfc patch.]
so score +1 for Johannes's patch. I think if it works out fine and there
are no false positives in further testing i'll put it up for pull into
v2.6.26 as well, as it is catching real bugs.
Ingo
next prev parent reply other threads:[~2008-06-20 15:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 21:57 [PATCH/RFC] remove irqs_disabled warning from local_bh_enable Johannes Berg
2008-06-17 23:08 ` David Miller
2008-06-17 23:55 ` Linus Torvalds
2008-06-18 7:01 ` Peter Zijlstra
2008-06-18 7:29 ` Johannes Berg
2008-06-20 13:46 ` Ingo Molnar
2008-06-20 15:27 ` Ingo Molnar
2008-06-20 15:36 ` Michael Buesch
2008-06-20 15:55 ` Ingo Molnar [this message]
2008-06-20 16:01 ` Michael Buesch
2008-06-20 16:18 ` Michael Buesch
2008-06-23 8:41 ` Ingo Molnar
2008-06-23 9:22 ` Michael Buesch
2008-06-27 5:33 ` Jeff Garzik
2008-06-27 10:53 ` Ingo Molnar
2008-06-27 10:56 ` Johannes Berg
2008-06-20 15:43 ` Johannes Berg
2008-06-20 15:46 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080620155541.GC6656@elte.hu \
--to=mingo@elte.hu \
--cc=david@identd.dyndns.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox